Skip to content

Commit 9184ff0

Browse files
Remove /FC from Windows builds (#406)
This is incompatible with recent goma updates. Rather than make it conditional on goma, it is removed entirely based on the arguments given in https://source.chromium.org/chromium/chromium/src/+/2e6d17c6948b2ca1e4dbd6bf15fcb52d32fa338d
1 parent e5b7a41 commit 9184ff0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

build/toolchain/win/BUILD.gn

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ template("msvc_toolchain") {
9494
# TODO(brettw) enable this when GN support in the binary has been rolled.
9595
#precompiled_header_type = "msvc"
9696
pdbname = "{{target_out_dir}}/{{target_output_name}}_c.pdb"
97-
command = "ninja -t msvc -e $env -- $cl /nologo /showIncludes /FC @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname"
97+
command = "ninja -t msvc -e $env -- $cl /nologo /showIncludes @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname"
9898
depsformat = "msvc"
9999
description = "CC {{output}}"
100100
outputs = [
@@ -115,7 +115,7 @@ template("msvc_toolchain") {
115115
if (is_clang && invoker.current_cpu == "x86") {
116116
flags = "-m32"
117117
}
118-
command = "ninja -t msvc -e $env -- $cl $flags /nologo /showIncludes /FC @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname"
118+
command = "ninja -t msvc -e $env -- $cl $flags /nologo /showIncludes @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname"
119119
depsformat = "msvc"
120120
description = "CXX {{output}}"
121121
outputs = [

0 commit comments

Comments
 (0)