Skip to content

Provide a testing API for the announce functionality #108495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nbayati opened this issue Jul 27, 2022 · 1 comment · Fixed by #109661
Closed

Provide a testing API for the announce functionality #108495

nbayati opened this issue Jul 27, 2022 · 1 comment · Fixed by #109661
Assignees
@nbayati
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) customer: google Various Google teams framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list

Comments

@nbayati
Copy link
Contributor

nbayati commented Jul 27, 2022

We don't have a testing API for the accessibility announcement function. Applications have to write tests reading the announcement logs and checking it against the expected message using hard-coded values. This is not scalable as we will break the existing tests if we add a new parameter (like PR #107568) or make any changes to the structure of the message dataMap.

We need to provide a testing API that allows the user to check the message and optionally the other parameters like textDirection and assertiveness.
@nbayati nbayati added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) customer: google Various Google teams labels Jul 27, 2022
@goderbauer goderbauer added the P2 Important issues not at the top of the work list label Aug 2, 2022
@nbayati nbayati self-assigned this Aug 2, 2022
@nbayati nbayati mentioned this issue Aug 17, 2022
Merged
8 tasks
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nbayati nbayati

Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) customer: google Various Google teams framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide test API for accessibility announcements nbayati/flutter
2 participants
@goderbauer @nbayati