-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Application does not redraw on Chrome <= 110 #146431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Frank3K, do you only experience this in dart-pad? I tested a spinner example on chrome 110 running on ubuntu and it seems to work fine for me. I'm trying to get a lower version of chrome to test as well. Screencast.from.04-09-2024.08.14.07.AM.webm |
This is not only using the dart-pad example; multiple users of our production application reported the issue on Chrome 103 on ChromeOS. Please note that we have patched the issue (as described in the original post); unfortunately some users (on Chrome 93 on ChromeOS) are now reporting that the application is upside down (as described in the original issue). For some other users the issue is solved. We are further investigating this. |
Regarding chrome 93, it seems it is not supported by flutter for deployment. See https://docs.flutter.dev/reference/supported-platforms
Please keep us updated. I'll also try to get chrome 103 to see if I can reproduce this issue |
We are aware of this. We just wanted to be complete. Note that the reported issue (application does not redraw) is mostly reported on Chrome 103.
Thanks. |
@Frank3K I got no more reports since then |
Hi @Frank3K, I managed to get chrome 103 but the spinner code sample seems to work as expected. Curious, in your application, do you use the canvaskit renderer or the html renderer? Dartpad is built with the canvaskit renderer so I'm trying to figure out if this is an issue with that renderer specifically. If you could also provide a complete minimal flutter code sample that reproduces the issue, that would be appreciated. Thank you Screencast.from.04-11-2024.06.24.21.AM.webm |
Hi @danagbemava-nc. Thanks for your investigation. To answer your questions:
|
I do see the same issue when I open dartpad with chrome 103 & 110 but not on newer versions of chrome. With dartpad, you can also notice that the dropdown doesn't disappear when the code sample is selected. Labeling for further investigation. Similar to #138827 Screencast.from.04-12-2024.06.49.17.AM.webm |
That's true. That's because a work-around has been introduced in flutter/engine#48515 and flutter/engine#48475 that specifically checks if the target browser is Chrome <= 110.
Nice observation. That could also be a missing re-draw. |
Moving to dart-lang/dart-pad#2958 |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Steps to reproduce
Expected results
The application redraws when needed. The loader should be hidden when the application is done loading.
Actual results
We have multiple clients that are complaining that our application does not work on "older Chromebooks". We have tracked down the issue and it seems that many of the old Chromebooks can not update beyond Chrome 103.
Our investigation found that:
drawImage
rendering on Chrome 110 or earlier engine#48515, created by @harryterkelsen.drawImage
is used instead. This fix was for a reported issue on Chrome <= 110 on Windows.main.dart.js
), our application works again as expected.We are willing to help on a PR, but we lack information on the situation of the original upside-down issue (#138827). We also doubt if the chosen work-around (from the linked PRs) is the best option. If it is possible to detect when the upside-down issue occurs, it might be better to keep on using
createImageBitmap
and pass theflipY
option.Code sample
https://dartpad.dev/?sample=counter&channel=master, but only on Chrome <= 110.
Screenshots or Video
Screenshots / Video demonstration
Recording on actual hardware (Lenovo N23 Chromebook, ChromeOS 103.0.5060.132)
Screen.recording.2024-04-08.13.56.12.webm
Browserling video recording on Windows 10.
Screen.Recording.2024-04-08.at.16.10.26-clip.mov
Logs
Logs
N/A as dartpad example is provided.
Flutter Doctor output
Doctor output
N/A as dartpad example is provided.
The text was updated successfully, but these errors were encountered: