Skip to content

[in_app_purchase_storekit] Prevent ios devices below ios 15 from enabling storekit #158894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #157558
LouiseHsu opened this issue Nov 13, 2024 · 5 comments · Fixed by flutter/packages#8110
Closed
Tracked by #157558
Assignees
Labels
p: in_app_purchase Plugin for in-app purchase P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team

Comments

@LouiseHsu
Copy link
Contributor

LouiseHsu commented Nov 13, 2024

Devices under ios 15 don't support storekit2, so add a version check.

@LouiseHsu LouiseHsu added p: in_app_purchase Plugin for in-app purchase P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team labels Nov 13, 2024
@LouiseHsu LouiseHsu self-assigned this Nov 14, 2024
@jmagman
Copy link
Member

jmagman commented Nov 19, 2024

I thought the plan was to add a fallback to StoreKit 1 when run on > iOS 15?

@LouiseHsu
Copy link
Contributor Author

yes, do they not mean the same thing? itll just revert to original storekit if its < ios 15

@jmagman
Copy link
Member

jmagman commented Nov 20, 2024

yes, do they not mean the same thing? itll just revert to original storekit if its < ios 15

I think your PR does what I was expecting: the app can call enableStoreKit2() and on < iOS 15 it drops back to StoreKit1, without the app author needing to handle that case or even know that it happened, right?

https://github.com/flutter/packages/blob/e95f6d8fce589a6dfbd8ceb6f2ddaa537ec2b2e6/packages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform.dart#L45-L46

@LouiseHsu
Copy link
Contributor Author

yes, do they not mean the same thing? itll just revert to original storekit if its < ios 15

I think your PR does what I was expecting: the app can call enableStoreKit2() and on < iOS 15 it drops back to StoreKit1, without the app author needing to handle that case or even know that it happened, right?

https://github.com/flutter/packages/blob/e95f6d8fce589a6dfbd8ceb6f2ddaa537ec2b2e6/packages/in_app_purchase/in_app_purchase_storekit/lib/src/in_app_purchase_storekit_platform.dart#L45-L46

yep! no action from them. I also enabled storekit 2 in the example app and it should work correctly using the appropriate implementation no matter the device version

Copy link

github-actions bot commented Dec 4, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: in_app_purchase Plugin for in-app purchase P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
None yet
2 participants