Skip to content

Commit 78ff122

Browse files
authored
Test cover more tests with leak tracking. (#133828)
1 parent 0f3bd90 commit 78ff122

File tree

7 files changed

+87
-74
lines changed

7 files changed

+87
-74
lines changed

packages/flutter/test/material/card_theme_test.dart

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ library;
99

1010
import 'package:flutter/material.dart';
1111
import 'package:flutter_test/flutter_test.dart';
12+
import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
1213

1314
void main() {
1415
test('CardTheme copyWith, ==, hashCode basics', () {
@@ -22,7 +23,7 @@ void main() {
2223
expect(identical(CardTheme.lerp(theme, theme, 0.5), theme), true);
2324
});
2425

25-
testWidgets('Material3 - Passing no CardTheme returns defaults', (WidgetTester tester) async {
26+
testWidgetsWithLeakTracking('Material3 - Passing no CardTheme returns defaults', (WidgetTester tester) async {
2627
final ThemeData theme = ThemeData(useMaterial3: true);
2728
await tester.pumpWidget(MaterialApp(
2829
theme: theme,
@@ -45,7 +46,7 @@ void main() {
4546
));
4647
});
4748

48-
testWidgets('Card uses values from CardTheme', (WidgetTester tester) async {
49+
testWidgetsWithLeakTracking('Card uses values from CardTheme', (WidgetTester tester) async {
4950
final CardTheme cardTheme = _cardTheme();
5051

5152
await tester.pumpWidget(MaterialApp(
@@ -67,7 +68,7 @@ void main() {
6768
expect(material.shape, cardTheme.shape);
6869
});
6970

70-
testWidgets('Card widget properties take priority over theme', (WidgetTester tester) async {
71+
testWidgetsWithLeakTracking('Card widget properties take priority over theme', (WidgetTester tester) async {
7172
const Clip clip = Clip.hardEdge;
7273
const Color color = Colors.orange;
7374
const Color shadowColor = Colors.pink;
@@ -102,7 +103,7 @@ void main() {
102103
expect(material.shape, shape);
103104
});
104105

105-
testWidgets('CardTheme properties take priority over ThemeData properties', (WidgetTester tester) async {
106+
testWidgetsWithLeakTracking('CardTheme properties take priority over ThemeData properties', (WidgetTester tester) async {
106107
final CardTheme cardTheme = _cardTheme();
107108
final ThemeData themeData = _themeData().copyWith(cardTheme: cardTheme);
108109

@@ -117,7 +118,7 @@ void main() {
117118
expect(material.color, cardTheme.color);
118119
});
119120

120-
testWidgets('Material3 - ThemeData properties are used when no CardTheme is set', (WidgetTester tester) async {
121+
testWidgetsWithLeakTracking('Material3 - ThemeData properties are used when no CardTheme is set', (WidgetTester tester) async {
121122
final ThemeData themeData = ThemeData(useMaterial3: true);
122123

123124
await tester.pumpWidget(MaterialApp(
@@ -131,7 +132,7 @@ void main() {
131132
expect(material.color, themeData.colorScheme.surface);
132133
});
133134

134-
testWidgets('Material3 - CardTheme customizes shape', (WidgetTester tester) async {
135+
testWidgetsWithLeakTracking('Material3 - CardTheme customizes shape', (WidgetTester tester) async {
135136
const CardTheme cardTheme = CardTheme(
136137
color: Colors.white,
137138
shape: BeveledRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(7))),
@@ -165,7 +166,7 @@ void main() {
165166
// support is deprecated and the APIs are removed, these tests
166167
// can be deleted.
167168

168-
testWidgets('Material2 - ThemeData properties are used when no CardTheme is set', (WidgetTester tester) async {
169+
testWidgetsWithLeakTracking('Material2 - ThemeData properties are used when no CardTheme is set', (WidgetTester tester) async {
169170
final ThemeData themeData = ThemeData(useMaterial3: false);
170171

171172
await tester.pumpWidget(MaterialApp(
@@ -179,7 +180,7 @@ void main() {
179180
expect(material.color, themeData.cardColor);
180181
});
181182

182-
testWidgets('Material2 - Passing no CardTheme returns defaults', (WidgetTester tester) async {
183+
testWidgetsWithLeakTracking('Material2 - Passing no CardTheme returns defaults', (WidgetTester tester) async {
183184
await tester.pumpWidget(MaterialApp(
184185
theme: ThemeData(useMaterial3: false),
185186
home: const Scaffold(
@@ -201,7 +202,7 @@ void main() {
201202
));
202203
});
203204

204-
testWidgets('Material2 - CardTheme customizes shape', (WidgetTester tester) async {
205+
testWidgetsWithLeakTracking('Material2 - CardTheme customizes shape', (WidgetTester tester) async {
205206
const CardTheme cardTheme = CardTheme(
206207
color: Colors.white,
207208
shape: BeveledRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(7))),

packages/flutter/test/material/checkbox_list_tile_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,7 @@ void main() {
743743
);
744744
});
745745

746-
testWidgets('Material2 - CheckboxListTile respects overlayColor in active/pressed/hovered states', (WidgetTester tester) async {
746+
testWidgetsWithLeakTracking('Material2 - CheckboxListTile respects overlayColor in active/pressed/hovered states', (WidgetTester tester) async {
747747
tester.binding.focusManager.highlightStrategy = FocusHighlightStrategy.alwaysTraditional;
748748

749749
const Color fillColor = Color(0xFF000000);
@@ -859,7 +859,7 @@ void main() {
859859
);
860860
});
861861

862-
testWidgets('Material3 - CheckboxListTile respects overlayColor in active/pressed/hovered states', (WidgetTester tester) async {
862+
testWidgetsWithLeakTracking('Material3 - CheckboxListTile respects overlayColor in active/pressed/hovered states', (WidgetTester tester) async {
863863
tester.binding.focusManager.highlightStrategy = FocusHighlightStrategy.alwaysTraditional;
864864

865865
const Color fillColor = Color(0xFF000000);

0 commit comments

Comments
 (0)