Skip to content

Commit db7196c

Browse files
authored
Revert "Add migrator to upgrade gradle version when conflict with And… (#125813)
�roid Studio bundled Java version is detected (#124085)" This reverts commit eba2a52.
1 parent b2f2232 commit db7196c

File tree

22 files changed

+40
-515
lines changed

22 files changed

+40
-515
lines changed

dev/integration_tests/android_custom_host_app/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/integration_tests/android_embedding_v2_smoke_test/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/integration_tests/android_host_app_v2_embedding/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/integration_tests/android_semantics_testing/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/integration_tests/android_views/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/integration_tests/external_ui/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/integration_tests/hybrid_android_views/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/integration_tests/module_host_with_custom_build_v2_embedding/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/integration_tests/non_nullable/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/integration_tests/platform_interaction/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/integration_tests/release_smoke_test/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/manual_tests/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

dev/tracing_tests/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7-all.zip

packages/flutter_tools/lib/src/android/gradle.dart

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,8 @@ import '../project.dart';
3131
import '../reporting/reporting.dart';
3232
import 'android_builder.dart';
3333
import 'android_sdk.dart';
34-
import 'android_studio.dart';
3534
import 'gradle_errors.dart';
3635
import 'gradle_utils.dart';
37-
import 'migrations/android_studio_java_gradle_conflict_migration.dart';
3836
import 'migrations/top_level_gradle_build_file_migration.dart';
3937
import 'multidex.dart';
4038

@@ -139,16 +137,13 @@ class AndroidGradleBuilder implements AndroidBuilder {
139137
required Usage usage,
140138
required GradleUtils gradleUtils,
141139
required Platform platform,
142-
required AndroidStudio? androidStudio,
143140
}) : _logger = logger,
144141
_fileSystem = fileSystem,
145142
_artifacts = artifacts,
146143
_usage = usage,
147144
_gradleUtils = gradleUtils,
148-
_androidStudio = androidStudio,
149145
_fileSystemUtils = FileSystemUtils(fileSystem: fileSystem, platform: platform),
150-
_processUtils = ProcessUtils(logger: logger, processManager: processManager),
151-
_platform = platform;
146+
_processUtils = ProcessUtils(logger: logger, processManager: processManager);
152147

153148
final Logger _logger;
154149
final ProcessUtils _processUtils;
@@ -157,8 +152,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
157152
final Usage _usage;
158153
final GradleUtils _gradleUtils;
159154
final FileSystemUtils _fileSystemUtils;
160-
final AndroidStudio? _androidStudio;
161-
final Platform _platform;
162155

163156
/// Builds the AAR and POM files for the current Flutter module or plugin.
164157
@override
@@ -265,15 +258,6 @@ class AndroidGradleBuilder implements AndroidBuilder {
265258

266259
final List<ProjectMigrator> migrators = <ProjectMigrator>[
267260
TopLevelGradleBuildFileMigration(project.android, _logger),
268-
AndroidStudioJavaGradleConflictMigration(_logger,
269-
project: project.android,
270-
androidStudio: _androidStudio,
271-
fileSystem: _fileSystem,
272-
processUtils: _processUtils,
273-
platform: _platform,
274-
os: globals.os,
275-
androidSdk: globals.androidSdk)
276-
,
277261
];
278262

279263
final ProjectMigration migration = ProjectMigration(migrators);

packages/flutter_tools/lib/src/android/gradle_utils.dart

Lines changed: 25 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -59,22 +59,6 @@ const String maxKnownAgpVersion = '8.1';
5959
final RegExp _androidGradlePluginRegExp =
6060
RegExp(r'com\.android\.tools\.build:gradle:(\d+\.\d+\.\d+)');
6161

62-
// Expected content format (with lines above and below).
63-
// Version can have 2 or 3 numbers.
64-
// 'distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-all.zip'
65-
// '^\s*' protects against commented out lines.
66-
final RegExp distributionUrlRegex =
67-
RegExp(r'^\s*distributionUrl\s*=\s*.*\.zip', multiLine: true);
68-
69-
// Modified version of the gradle distribution url match designed to only match
70-
// gradle.org urls so that we can guarantee any modifications to the url
71-
// still points to a hosted zip.
72-
final RegExp gradleOrgVersionMatch =
73-
RegExp(
74-
r'^\s*distributionUrl\s*=\s*https\\://services\.gradle\.org/distributions/gradle-((?:\d|\.)+)-(.*)\.zip',
75-
multiLine: true
76-
);
77-
7862
// From https://docs.gradle.org/current/userguide/command_line_interface.html#command_line_interface
7963
const String gradleVersionFlag = r'--version';
8064

@@ -185,49 +169,42 @@ String getGradleVersionForAndroidPlugin(Directory directory, Logger logger) {
185169
return getGradleVersionFor(androidPluginVersion ?? 'unknown');
186170
}
187171

188-
/// Returns the gradle file from the top level directory.
189-
/// The returned file is not guaranteed to be present.
190-
File getGradleWrapperFile(Directory directory) {
191-
return directory.childDirectory(gradleDirectoryName)
192-
.childDirectory(gradleWrapperDirectoryName)
193-
.childFile(gradleWrapperPropertiesFilename);
194-
}
195-
196-
/// Parses the gradle wrapper distribution url to return a string containing
197-
/// the version number.
198-
///
199-
/// Expected input is of the form '...gradle-7.4.2-all.zip', and the output
200-
/// would be of the form '7.4.2'.
201-
String? parseGradleVersionFromDistributionUrl(String? distributionUrl) {
202-
if (distributionUrl == null) {
203-
return null;
204-
}
205-
final List<String> zipParts = distributionUrl.split('-');
206-
if (zipParts.length < 2) {
207-
return null;
208-
}
209-
return zipParts[1];
210-
}
211-
212172
/// Returns either the gradle-wrapper.properties value from the passed in
213173
/// [directory] or if not present the version available in local path.
214174
///
215175
/// If gradle version is not found null is returned.
216-
/// [directory] should be an android directory with a build.gradle file.
176+
/// [directory] should be and android directory with a build.gradle file.
217177
Future<String?> getGradleVersion(
218178
Directory directory, Logger logger, ProcessManager processManager) async {
219-
final File propertiesFile = getGradleWrapperFile(directory);
179+
final File propertiesFile = directory
180+
.childDirectory(gradleDirectoryName)
181+
.childDirectory(gradleWrapperDirectoryName)
182+
.childFile(gradleWrapperPropertiesFilename);
220183

221184
if (propertiesFile.existsSync()) {
222185
final String wrapperFileContent = propertiesFile.readAsStringSync();
223186

187+
// Expected content format (with lines above and below).
188+
// Version can have 2 or 3 numbers.
189+
// 'distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-all.zip'
190+
// '^\s*' protects against commented out lines.
191+
final RegExp distributionUrlRegex =
192+
RegExp(r'^\s*distributionUrl\s?=\s?.*\.zip', multiLine: true);
193+
224194
final RegExpMatch? distributionUrl =
225195
distributionUrlRegex.firstMatch(wrapperFileContent);
226196
if (distributionUrl != null) {
227-
final String? gradleVersion =
228-
parseGradleVersionFromDistributionUrl(distributionUrl.group(0));
229-
if (gradleVersion != null) {
230-
return gradleVersion;
197+
// Expected content: 'gradle-7.4.2-all.zip'
198+
final String? gradleZip = distributionUrl.group(0);
199+
if (gradleZip != null) {
200+
final List<String> zipParts = gradleZip.split('-');
201+
if (zipParts.length > 2) {
202+
final String gradleVersion = zipParts[1];
203+
return gradleVersion;
204+
} else {
205+
// Did not find gradle zip url. Likely this is a bug in our parsing.
206+
logger.printWarning(_formatParseWarning(wrapperFileContent));
207+
}
231208
} else {
232209
// Did not find gradle zip url. Likely this is a bug in our parsing.
233210
logger.printWarning(_formatParseWarning(wrapperFileContent));
@@ -271,7 +248,7 @@ OS: Mac OS X 13.2.1 aarch64
271248
final RegExpMatch? version =
272249
gradleVersionRegex.firstMatch(gradleVersionVerbose);
273250
if (version == null) {
274-
// Most likely a bug in our parse implementation/regex.
251+
// Most likley a bug in our parse implementation/regex.
275252
logger.printWarning(_formatParseWarning(gradleVersionVerbose));
276253
return null;
277254
}
@@ -323,7 +300,7 @@ String _formatParseWarning(String content) {
323300
//
324301
// Source of truth found here:
325302
// https://developer.android.com/studio/releases/gradle-plugin#updating-gradle
326-
// AGP has a minimum version of gradle required but no max starting at
303+
// AGP has a minimim version of gradle required but no max starting at
327304
// AGP version 2.3.0+.
328305
bool validateGradleAndAgp(Logger logger,
329306
{required String? gradleV, required String? agpV}) {

0 commit comments

Comments
 (0)