Move plugin tool tests over (#3606)

Author: Emmanuel Garcia

.cirrus.yml

@@ -16,10 +16,12 @@ task:
     - flutter channel master
     - flutter upgrade
     - git fetch origin master
-  submodules_script:
-    - git submodule init
-    - git submodule update
   matrix:
+    - name: plugin_tools_tests
+      script:
+        - cd script/tool
+        - pub get
+        - CIRRUS_BUILD_ID=null pub run test
     - name: publishable
       script:
         - flutter channel master
@@ -132,9 +134,6 @@ task:
     - flutter channel master
     - flutter upgrade
     - git fetch origin master
-  submodules_script:
-    - git submodule init
-    - git submodule update
   matrix:
     - name: build-linux+drive-examples
       install_script:
@@ -161,9 +160,6 @@ task:
     - flutter channel master
     - flutter upgrade
     - git fetch origin master
-  submodules_script:
-    - git submodule init
-    - git submodule update
   create_simulator_script:
     - xcrun simctl list
     - xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-11 com.apple.CoreSimulator.SimRuntime.iOS-14-3 | xargs xcrun simctl boot
@@ -222,9 +218,6 @@ task:
     - flutter channel master
     - flutter upgrade
     - git fetch origin master
-  submodules_script:
-    - git submodule init
-    - git submodule update
   create_simulator_script:
     - xcrun simctl list
     - xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-X com.apple.CoreSimulator.SimRuntime.iOS-13-3 | xargs xcrun simctl boot
@@ -254,9 +247,6 @@ task:
     - flutter channel master
     - flutter upgrade
     - git fetch origin master
-  submodules_script:
-    - git submodule init
-    - git submodule update
   matrix:
     - name: build_all_plugins_app
       script:

script/tool/pubspec.yaml

@@ -21,5 +21,10 @@ dependencies:
   http_multi_server: ^2.2.0
   collection: 1.14.13
 
+dev_dependencies:
+  matcher: ^0.12.6
+  mockito: ^4.1.1
+  pedantic: 1.8.0
+
 environment:
   sdk: ">=2.3.0 <3.0.0"

script/tool/test/analyze_command_test.dart

@@ -0,0 +1,93 @@
+import 'package:args/command_runner.dart';
+import 'package:file/file.dart';
+import 'package:flutter_plugin_tools/src/analyze_command.dart';
+import 'package:flutter_plugin_tools/src/common.dart';
+import 'package:test/test.dart';
+
+import 'mocks.dart';
+import 'util.dart';
+
+void main() {
+  RecordingProcessRunner processRunner;
+  CommandRunner runner;
+
+  setUp(() {
+    initializeFakePackages();
+    processRunner = RecordingProcessRunner();
+    final AnalyzeCommand analyzeCommand = AnalyzeCommand(
+        mockPackagesDir, mockFileSystem,
+        processRunner: processRunner);
+
+    runner = CommandRunner<Null>('analyze_command', 'Test for analyze_command');
+    runner.addCommand(analyzeCommand);
+  });
+
+  tearDown(() {
+    mockPackagesDir.deleteSync(recursive: true);
+  });
+
+  test('analyzes all packages', () async {
+    final Directory plugin1Dir = await createFakePlugin('a');
+    final Directory plugin2Dir = await createFakePlugin('b');
+
+    final MockProcess mockProcess = MockProcess();
+    mockProcess.exitCodeCompleter.complete(0);
+    processRunner.processToReturn = mockProcess;
+    await runner.run(<String>['analyze']);
+
+    expect(
+        processRunner.recordedCalls,
+        orderedEquals(<ProcessCall>[
+          ProcessCall('pub', <String>['global', 'activate', 'tuneup'],
+              mockPackagesDir.path),
+          ProcessCall('flutter', <String>['packages', 'get'], plugin1Dir.path),
+          ProcessCall('flutter', <String>['packages', 'get'], plugin2Dir.path),
+          ProcessCall('pub', <String>['global', 'run', 'tuneup', 'check'],
+              plugin1Dir.path),
+          ProcessCall('pub', <String>['global', 'run', 'tuneup', 'check'],
+              plugin2Dir.path),
+        ]));
+  });
+
+  group('verifies analysis settings', () {
+    test('fails analysis_options.yaml', () async {
+      await createFakePlugin('foo', withExtraFiles: <List<String>>[
+        <String>['analysis_options.yaml']
+      ]);
+
+      await expectLater(() => runner.run(<String>['analyze']),
+          throwsA(const TypeMatcher<ToolExit>()));
+    });
+
+    test('fails .analysis_options', () async {
+      await createFakePlugin('foo', withExtraFiles: <List<String>>[
+        <String>['.analysis_options']
+      ]);
+
+      await expectLater(() => runner.run(<String>['analyze']),
+          throwsA(const TypeMatcher<ToolExit>()));
+    });
+
+    test('takes an allow list', () async {
+      final Directory pluginDir =
+          await createFakePlugin('foo', withExtraFiles: <List<String>>[
+        <String>['analysis_options.yaml']
+      ]);
+
+      final MockProcess mockProcess = MockProcess();
+      mockProcess.exitCodeCompleter.complete(0);
+      processRunner.processToReturn = mockProcess;
+      await runner.run(<String>['analyze', '--custom-analysis', 'foo']);
+
+      expect(
+          processRunner.recordedCalls,
+          orderedEquals(<ProcessCall>[
+            ProcessCall('pub', <String>['global', 'activate', 'tuneup'],
+                mockPackagesDir.path),
+            ProcessCall('flutter', <String>['packages', 'get'], pluginDir.path),
+            ProcessCall('pub', <String>['global', 'run', 'tuneup', 'check'],
+                pluginDir.path),
+          ]));
+    });
+  });
+}