From 27fa4e279057ffbbaa34861ec6ca8d8ff00787be Mon Sep 17 00:00:00 2001 From: Dan Field Date: Tue, 27 Oct 2020 10:54:09 -0700 Subject: [PATCH] Remove unnecessary work around from test in prep for vm_service migration --- packages/android_alarm_manager/CHANGELOG.md | 4 +++ .../example/test_driver/integration_test.dart | 25 ------------------- packages/android_alarm_manager/pubspec.yaml | 2 +- 3 files changed, 5 insertions(+), 26 deletions(-) diff --git a/packages/android_alarm_manager/CHANGELOG.md b/packages/android_alarm_manager/CHANGELOG.md index 1913f97a8218..ab878a6562f4 100644 --- a/packages/android_alarm_manager/CHANGELOG.md +++ b/packages/android_alarm_manager/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.4.5+16 + +* Remove unnecessary workaround from test. + ## 0.4.5+15 * Update android compileSdkVersion to 29. diff --git a/packages/android_alarm_manager/example/test_driver/integration_test.dart b/packages/android_alarm_manager/example/test_driver/integration_test.dart index 4e32b483f8d7..ed54518d7d00 100644 --- a/packages/android_alarm_manager/example/test_driver/integration_test.dart +++ b/packages/android_alarm_manager/example/test_driver/integration_test.dart @@ -7,39 +7,14 @@ import 'dart:convert'; import 'dart:io'; import 'package:flutter_driver/flutter_driver.dart'; -import 'package:vm_service_client/vm_service_client.dart'; - -Future> resumeIsolatesOnPause( - FlutterDriver driver) async { - final VM vm = await driver.serviceClient.getVM(); - for (VMIsolateRef isolateRef in vm.isolates) { - final VMIsolate isolate = await isolateRef.load(); - if (isolate.isPaused) { - await isolate.resume(); - } - } - return driver.serviceClient.onIsolateRunnable - .asBroadcastStream() - .listen((VMIsolateRef isolateRef) async { - final VMIsolate isolate = await isolateRef.load(); - if (isolate.isPaused) { - await isolate.resume(); - } - }); -} Future main() async { final FlutterDriver driver = await FlutterDriver.connect(); - // flutter drive causes isolates to be paused on spawn. The background isolate - // for this plugin will need to be resumed for the test to pass. - final StreamSubscription subscription = - await resumeIsolatesOnPause(driver); final String data = await driver.requestData( null, timeout: const Duration(minutes: 1), ); await driver.close(); - await subscription.cancel(); final Map result = jsonDecode(data); exit(result['result'] == 'true' ? 0 : 1); } diff --git a/packages/android_alarm_manager/pubspec.yaml b/packages/android_alarm_manager/pubspec.yaml index e12bedd11b70..80327326fb8a 100644 --- a/packages/android_alarm_manager/pubspec.yaml +++ b/packages/android_alarm_manager/pubspec.yaml @@ -4,7 +4,7 @@ description: Flutter plugin for accessing the Android AlarmManager service, and # 0.4.y+z is compatible with 1.0.0, if you land a breaking change bump # the version to 2.0.0. # See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0 -version: 0.4.5+15 +version: 0.4.5+16 homepage: https://github.com/flutter/plugins/tree/master/packages/android_alarm_manager dependencies: