Skip to content

[Animations] Add title property (AppBar) for All the Routes. #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Raj-Dave368 opened this issue Oct 15, 2020 · 11 comments
Closed

[Animations] Add title property (AppBar) for All the Routes. #564

Raj-Dave368 opened this issue Oct 15, 2020 · 11 comments
Labels
enhancement New feature or request p2 polish
Milestone

Comments

@Raj-Dave368
Copy link

Raj-Dave368 commented Oct 15, 2020

Description

There is no title on some Route Page which can show, What type of Animation Page is Demonstrating.
image

  • When I was testing the app I was Just clicking ListTile(main.dart) Randomly,

image

  • And I was navigating to Corresponding Page But After Navigating to the Screen I didn't know which type of Animation I am Trying (Because: Page Doesn't Contain title On The AppBar).

image

  • Before Navigating to Any Page, I had to first Remember the ListTile.title. [a few pages have a title, but I'll like to have for all]

image

But I would Like to Make it More User Friendly and Easy to Use.
Something like this:

image

This is my first issue and I would like to Solve this Issue.

@Raj-Dave368
Copy link
Author

Raj-Dave368 commented Oct 15, 2020

@RedBrogdon @AyushBherwani1998 Please Review my issue, if the corresponding issue does not exist already, then I would like to Make a PR Because I have done this minor Changes, which has a Huge Impact(80/20 principle).

Thanks,
- Your new contributor.

@AyushBherwani1998
Copy link
Member

Hey @Raj-Dave368, thanks for opening the issue. IMO, it will make the UX better. We still have to wait for Andrew's take on this. Till then, you can make changes in your system, and if this is something the samples need, you can submit a PR.

@RedBrogdon
Copy link
Contributor

I agree, and I imagine @johnpryan would as well (though he's free to disagree with me 😄 ).

@Alabhya268
Copy link
Contributor

@Raj-Dave368 are you still working on this issue? If not I would like to work on this issue.

@Alabhya268
Copy link
Contributor

@RedBrogdon , I want to work on this issue could you please assign it to me ?

@adarsh-technocrat
Copy link
Contributor

@Raj-Dave368 is this issue is closed?

@adarsh-technocrat
Copy link
Contributor

Hello, @RedBrogdon @AyushBherwani1998 I'm new to the open-source contribution and I really want to work on the issues and contribute to it can you please guide me from where I should start with or what is the right way to start. I found this issue in which I like to land my first PR if no one is working on it.

Thank you!

@Raj-Dave368
Copy link
Author

Sorry for late reply, i had exam and still I am busy in some other work and cannot work on this issue.
@Alabhya268 you can work on this issue if you want.
Thank you

@Raj-Dave368 Raj-Dave368 removed their assignment Dec 9, 2020
@Alabhya268
Copy link
Contributor

Sorry for late reply, i had exam and still I am busy in some other work and cannot work on this issue.
@Alabhya268 you can work on this issue if you want.
Thank you

Thanks@Raj-Dave368 , I'll soon open PR for this issue.

@Raj-Dave368
Copy link
Author

Fine
I m closing this PR.
Sorry @RedBrogdon

@RedBrogdon
Copy link
Contributor

Fine
I m closing this PR.
Sorry @RedBrogdon

That's okay. Good luck with your classwork!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p2 polish
Projects
None yet
5 participants