Skip to content

TOML parser #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
milancurcic opened this issue Jul 24, 2020 · 3 comments · Fixed by #157
Closed

TOML parser #149

milancurcic opened this issue Jul 24, 2020 · 3 comments · Fixed by #157

Comments

@milancurcic
Copy link
Member

Part of #136

I found 2, both support TOML v0.5 spec:

  • toml-f which is pure Fortran, but unfortunately GPLv3-licensed. We could ask the author to offer a more permissive license beside GPL.
  • f_tomlc99 which interfaces a C parser. MIT-licensed.

So each presents an integration challenge.

@certik
Copy link
Member

certik commented Jul 24, 2020

In terms of easiness of use, we should try to stick to pure Fortran packages for fpm dependencies, since the non Fortran dependencies must be built somehow on all platforms for all users, and that can get messy --- we discussed just loading such packages from Conda as binaries on all platforms, which I think is preferable, but I was hoping to integrate with Conda in the Fortran fpm, and not worry about it for haskell fpm.

As such, we can probably quite easily improve haskell fpm to be able to compile C or C++ files inside an fpm package if we have to. But 3rd party non-Fortran dependencies will cause more issues I feel.

Conclusion: We have to tackle robust building / using of non Fortran dependencies, but I would worry about it a bit later, once Fortran fpm works well. So I would just stick to pure Fortran for now.

@certik
Copy link
Member

certik commented Jul 24, 2020

I asked the author of toml-f at awvwgk/toml-f#1 if he would be willing to relicence. If he would, that would be awesome, I think it's exactly what we are looking for.

@LKedward
Copy link
Member

It looks like toml-f will indeed be re-licensed to dual MIT/Apache-2.0 in an upcoming PR: awvwgk/toml-f#2. I notice this PR also includes an fpm.toml (though it relies on meson currently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants