Skip to content

Commit b347c7d

Browse files
authored
Merge pull request #1 from framely/fixthings
disable a suspicious code block that extracts get/set functions
2 parents a1a5498 + c757c70 commit b347c7d

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

server/src/main/kotlin/org/javacs/kt/completion/Completions.kt

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -181,14 +181,15 @@ private fun completionItem(d: DeclarationDescriptor, surroundingElement: KtEleme
181181

182182
result.label = methodSignature.find(result.detail)?.groupValues?.get(1) ?: result.label
183183

184-
if (isNotStaticJavaMethod(d) && (isGetter(d) || isSetter(d))) {
185-
val name = extractPropertyName(d)
186-
187-
result.detail += " (from ${result.label})"
188-
result.label = name
189-
result.insertText = name
190-
result.filterText = name
191-
}
184+
// TODO: @xiaobo; sceptical about this code block, it might mistakenly extract function names
185+
// if (isNotStaticJavaMethod(d) && (isGetter(d) || isSetter(d))) {
186+
// val name = extractPropertyName(d)
187+
//
188+
// result.detail += " (from ${result.label})"
189+
// result.label = name
190+
// result.insertText = name
191+
// result.filterText = name
192+
// }
192193

193194
if (KotlinBuiltIns.isDeprecated(d)) {
194195
result.tags = listOf(CompletionItemTag.Deprecated)

0 commit comments

Comments
 (0)