Skip to content

Make Samples comparable by value again #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shsms opened this issue May 23, 2023 · 1 comment · Fixed by #401
Closed

Make Samples comparable by value again #399

shsms opened this issue May 23, 2023 · 1 comment · Fixed by #401
Assignees
@leandro-lucarella-frequenz
Labels
part:data-pipeline Affects the data pipeline type:bug Something isn't working
Milestone
v0.21.0

Comments

@shsms
Copy link
Contributor

shsms commented May 23, 2023

What happened?

Equality comparison between two Sample objects is passing even when they have different values.

What did you expect instead?

Two Sample objects should be considered equal only if they have the same timestamp and value.

Affected version(s)

No response

Affected part(s)

Data pipeline (part:data-pipeline)

Extra information

No response
@shsms shsms added priority:❓ We need to figure out how soon this should be addressed type:bug Something isn't working labels May 23, 2023
@keywordlabeler keywordlabeler bot added the part:data-pipeline Affects the data pipeline label May 23, 2023
@shsms shsms added status:blocked Other issues must be resolved before this can be worked on and removed priority:❓ We need to figure out how soon this should be addressed labels May 23, 2023
@shsms
Copy link
Contributor Author

shsms commented May 23, 2023

Blocked by #148

@shsms shsms added this to the v0.21.0 milestone May 23, 2023
@leandro-lucarella-frequenz leandro-lucarella-frequenz removed the status:blocked Other issues must be resolved before this can be worked on label May 23, 2023
Merged
@github-project-automation github-project-automation bot moved this from To do to Done in Python SDK Roadmap May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandro-lucarella-frequenz leandro-lucarella-frequenz

Labels
part:data-pipeline Affects the data pipeline type:bug Something isn't working
Projects
Python SDK Roadmap
Status: Done
Milestone
v0.21.0
Development

Successfully merging a pull request may close this issue.

Drop support for Python versions older than 3.11 llucax/frequenz-sdk-python
2 participants
@shsms @leandro-lucarella-frequenz