Skip to content

Commit 3c247f5

Browse files
authored
Allow non-str kwargs to FileSelector (#1437)
1 parent f7b454e commit 3c247f5

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

fsspec/gui.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ def __init__(self, url=None, filters=None, ignore=None, kwargs=None):
242242
else:
243243
self.init_protocol, url = "file", os.getcwd()
244244
self.init_url = url
245-
self.init_kwargs = kwargs or "{}"
245+
self.init_kwargs = (kwargs if isinstance(kwargs, str) else str(kwargs)) or "{}"
246246
self.filters = filters
247247
self.ignore = [re.compile(i) for i in ignore or []]
248248
self._fs = None

fsspec/implementations/reference.py

+1
Original file line numberDiff line numberDiff line change
@@ -794,6 +794,7 @@ def cat(self, path, recursive=False, on_error="raise", **kwargs):
794794
raise NotImplementedError
795795
if isinstance(path, list) and (recursive or any("*" in p for p in path)):
796796
raise NotImplementedError
797+
# TODO: if references is lazy, pre-fetch all paths in batch before access
797798
proto_dict = _protocol_groups(path, self.references)
798799
out = {}
799800
for proto, paths in proto_dict.items():

fsspec/tests/test_gui.py

+4
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,7 @@ def test_kwargs(tmpdir):
1717
gui = fsspec.gui.FileSelector(f"file://{tmpdir}", kwargs="{'auto_mkdir': True}")
1818

1919
assert gui.fs.auto_mkdir
20+
21+
gui = fsspec.gui.FileSelector(f"file://{tmpdir}", kwargs={"auto_mkdir": True})
22+
23+
assert gui.fs.auto_mkdir

0 commit comments

Comments
 (0)