ios: Code style enhancements

* Remove needless @synchronized blocks
* Consistent braces and pointer declarations

Author: mortend

ios/RNUnity/RNUnity.h

@@ -19,7 +19,7 @@
 
 @protocol RNUnityProxy <NSObject>
 
-- (void)emitEvent:(const char*)name data:(const char*)data;
+- (void)emitEvent:(const char *)name data:(const char *)data;
 
 @end
 
@@ -29,10 +29,10 @@
 + (id<RNUnityFramework>)getInstance;
 - (id<RNUnityAppController>)appController;
 
-- (void)setExecuteHeader:(const void*)header;
-- (void)setDataBundleId:(const char*)bundleId;
+- (void)setExecuteHeader:(const void *)header;
+- (void)setDataBundleId:(const char *)bundleId;
 
-- (void)runEmbeddedWithArgc:(int)argc argv:(char*[])argv appLaunchOpts:(NSDictionary*)appLaunchOpts;
+- (void)runEmbeddedWithArgc:(int)argc argv:(char *[])argv appLaunchOpts:(NSDictionary *)appLaunchOpts;
 
 - (void)unloadApplication;
 
@@ -42,7 +42,7 @@
 
 - (void)pause:(bool)pause;
 
-- (void)sendMessageToGOWithName:(const char*)goName functionName:(const char*)name message:(const char*)msg;
+- (void)sendMessageToGOWithName:(const char *)goName functionName:(const char *)name message:(const char *)msg;
 
 - (void)setRNUnityProxy:(id<RNUnityProxy>)proxy;
 
@@ -52,20 +52,20 @@
 @interface RNUnity : RCTEventEmitter <RCTBridgeModule>
 
 @property (atomic, class) int argc;
-@property (atomic, class) char** argv;
+@property (atomic, class) char **argv;
 
 @property (atomic, class) id<RNUnityFramework> ufw;
 
 + (void)initFromSwift;
 
-+ (void)applicationWillResignActive:(UIApplication*)application;
-+ (void)applicationDidEnterBackground:(UIApplication*)application;
-+ (void)applicationWillEnterForeground:(UIApplication*)application;
-+ (void)applicationDidBecomeActive:(UIApplication*)application;
-+ (void)applicationWillTerminate:(UIApplication*)application;
++ (void)applicationWillResignActive:(UIApplication *)application;
++ (void)applicationDidEnterBackground:(UIApplication *)application;
++ (void)applicationWillEnterForeground:(UIApplication *)application;
++ (void)applicationDidBecomeActive:(UIApplication *)application;
++ (void)applicationWillTerminate:(UIApplication *)application;
 
-+ (id<RNUnityFramework>)launchWithOptions:(NSDictionary*)launchOptions;
++ (id<RNUnityFramework>)launchWithOptions:(NSDictionary *)launchOptions;
 
-+ (void)emitEvent:(const char*)name data:(const char*)data;
++ (void)emitEvent:(const char *)name data:(const char *)data;
 
 @end

ios/RNUnity/RNUnity.m

@@ -18,84 +18,65 @@ @implementation RNUnity
 RCT_EXPORT_MODULE(RNUnity)
 
 static int _RNUnity_argc;
-static char ** _RNUnity_argv;
+static char **_RNUnity_argv;
 static id<RNUnityFramework> _RNUnity_ufw;
 static RNUnity *_RNUnity_sharedInstance;
 
 + (char **)argv {
-    @synchronized (self) {
-        return _RNUnity_argv;
-    }
+    return _RNUnity_argv;
 }
 
 + (void)setArgv:(char **)argv {
-    @synchronized (self) {
-        _RNUnity_argv = argv;
-    }
+    _RNUnity_argv = argv;
 }
 
 + (int)argc {
-    @synchronized (self) {
-        return _RNUnity_argc;
-    }
+    return _RNUnity_argc;
 }
 
 + (void)setArgc:(int)argc {
-    @synchronized (self) {
-        _RNUnity_argc = argc;
-    }
+    _RNUnity_argc = argc;
 }
 
 + (id<RNUnityFramework>)ufw {
-    @synchronized (self) {
-        return _RNUnity_ufw;
-    }
+    return _RNUnity_ufw;
 }
 
 + (void)setUfw:(id<RNUnityFramework>)ufw {
-    @synchronized (self) {
-        _RNUnity_ufw = ufw;
-    }
+    _RNUnity_ufw = ufw;
 }
 
 + (void)initFromSwift {
-    NSLog(@"RNUnity.initFromSwift()");
     _RNUnity_argc = *_NSGetArgc();
     _RNUnity_argv = *_NSGetArgv();
 }
 
-+ (void)applicationWillResignActive:(UIApplication*)application {
-    NSLog(@"RNUnity.applicationWillResignActive()");
++ (void)applicationWillResignActive:(UIApplication *)application {
     [[[self ufw] appController] applicationWillResignActive: application];
 }
 
-+ (void)applicationDidEnterBackground:(UIApplication*)application {
-    NSLog(@"RNUnity.applicationDidEnterBackground()");
++ (void)applicationDidEnterBackground:(UIApplication *)application {
     [[[self ufw] appController] applicationDidEnterBackground: application];
 }
 
-+ (void)applicationWillEnterForeground:(UIApplication*)application {
-    NSLog(@"RNUnity.applicationWillEnterForeground()");
++ (void)applicationWillEnterForeground:(UIApplication *)application {
     [[[self ufw] appController] applicationWillEnterForeground: application];
 }
 
-+ (void)applicationDidBecomeActive:(UIApplication*)application {
-    NSLog(@"RNUnity.applicationDidBecomeActive()");
++ (void)applicationDidBecomeActive:(UIApplication *)application {
     [[[self ufw] appController] applicationDidBecomeActive: application];
 }
 
-+ (void)applicationWillTerminate:(UIApplication*)application {
-    NSLog(@"RNUnity.applicationWillTerminate()");
++ (void)applicationWillTerminate:(UIApplication *)application {
     [[[self ufw] appController] applicationWillTerminate: application];
 }
 
-+ (id<RNUnityFramework>)launchWithOptions:(NSDictionary*)applaunchOptions {
-
-    NSString* bundlePath = nil;
++ (id<RNUnityFramework>)launchWithOptions:(NSDictionary *)applaunchOptions {
+    NSString *bundlePath = nil;
     bundlePath = [[NSBundle mainBundle] bundlePath];
     bundlePath = [bundlePath stringByAppendingString: @"/Frameworks/UnityFramework.framework"];
 
-    NSBundle* bundle = [NSBundle bundleWithPath: bundlePath];
+    NSBundle *bundle = [NSBundle bundleWithPath: bundlePath];
     if ([bundle isLoaded] == false) [bundle load];
 
     id<RNUnityFramework> framework = [bundle.principalClass getInstance];
@@ -155,13 +136,12 @@ - (dispatch_queue_t)methodQueue {
 RCT_EXPORT_METHOD(sendMessage:(NSString *)gameObject
                   functionName:(NSString *)functionName
                   message:(NSString *)message) {
-
     if (_RNUnity_sharedInstance) {
         [[RNUnity ufw] sendMessageToGOWithName:[gameObject UTF8String] functionName:[functionName UTF8String] message:[message UTF8String]];
     }
 }
 
-+ (void)emitEvent:(const char*)name data:(const char*)data {
++ (void)emitEvent:(const char *)name data:(const char *)data {
     [_RNUnity_sharedInstance emitEvent:[NSString stringWithUTF8String:name] data:[NSString stringWithUTF8String:data]];
 }
 

ios/RNUnity/UnityResponderView.m

@@ -1,12 +1,11 @@
 #import "UnityResponderView.h"
 #import "RNUnity.h"
 
-UIView* _unityView;
+UIView *_unityView;
 
 @implementation UnityResponderView
 
-- (id)initWithFrame:(CGRect)frame
-{
+- (id)initWithFrame:(CGRect)frame {
     self = [super initWithFrame:frame];
 
     if (!_unityView) {
@@ -16,14 +15,13 @@ - (id)initWithFrame:(CGRect)frame
     return self;
 }
 
-- (void)layoutSubviews
-{
+- (void)layoutSubviews {
     [super layoutSubviews];
     [_unityView removeFromSuperview];
     _unityView.frame = self.bounds;
     [self insertSubview:_unityView atIndex:0];
 
-    UIWindow * main = [[[UIApplication sharedApplication] delegate] window];
+    UIWindow *main = [[[UIApplication sharedApplication] delegate] window];
 
     if (main != nil) {
         [main makeKeyAndVisible];

ios/RNUnity/UnityResponderViewManager.m

@@ -6,8 +6,7 @@ @implementation UnityResponderViewManager
 
 RCT_EXPORT_MODULE(UnityResponderView)
 
-- (UIView *)view
-{
+- (UIView *)view {
     return [UnityResponderView new];
 }