Skip to content

Definitions on JDK and Kotlin Standard Library #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daplf opened this issue Sep 30, 2021 · 1 comment
Open

Definitions on JDK and Kotlin Standard Library #308

daplf opened this issue Sep 30, 2021 · 1 comment

Comments

@daplf
Copy link
Contributor

daplf commented Sep 30, 2021

At the moment, definitions don't work for symbols in the JDK and the Kotlin standard library (not even through decompiling).

The kotlin standard library jars are included as any other jars in the classpath, but the compiler has the descriptors with the source set to NO_SOURCE, which leads to it not being able to find the files.

For the symbols in the JDK, it never even gets that far. BindingContext.getSliceContents returns an empty list here: https://github.com/fwcd/kotlin-language-server/blob/main/server/src/main/kotlin/org/javacs/kt/CompiledFile.kt#L67

Supporting this would be cool. Supporting source jars for the JDK might also require some additional work, since I'm not sure maven will give us these through the sources goal.

@fwcd
Copy link
Owner

fwcd commented Oct 3, 2023

Note that JDK symbol lookup has already shipped a while ago in #339, but I'll leave this open to track progress on support for definitions in the Kotlin standard library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants