Skip to content

JVM Targets unable to be selected #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adamgoose opened this issue Aug 4, 2022 · 1 comment · Fixed by #380
Closed

JVM Targets unable to be selected #378

adamgoose opened this issue Aug 4, 2022 · 1 comment · Fixed by #380

Comments

@adamgoose
Copy link

According to jvmTargetFrom, there's no way to select JVM 16 or 17.

I was able to get a build passing by simply adding a 17 case.
@fwcd
Copy link
Owner

fwcd commented Aug 4, 2022

We should probably just replace our own implementation with a call to JvmTarget.fromString to future-proof this

@omar25h omar25h mentioned this issue Aug 5, 2022
Merged
@fwcd fwcd closed this as completed in #380 Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Depend on Kotlin's implementation of parsing JVM target omar25h/kotlin-language-server
2 participants
@adamgoose @fwcd