Skip to content

Commit 637cbd1

Browse files
Merge branch 'getsentry:master' into patch-1
2 parents 8abc526 + 2ab89c3 commit 637cbd1

File tree

353 files changed

+4479
-1794
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

353 files changed

+4479
-1794
lines changed

develop-docs/backend/application-domains/database-migrations/index.mdx

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,19 @@ Note that if you have added a new model, you also need to import the model in `_
5454

5555
When merging to master you might notice a conflict with `migrations_lockfile.txt`. This file is in place to help us avoid merging two migrations with the same migration number to master, and if you're conflicting with it then it's likely someone has committed a migration ahead of you.
5656

57-
To resolve this, rebase against latest master, delete your current migration and then regenerate it. If your migration was custom, just save the operations in a text file somewhere so that you can reapply them on the regenerated migration.
57+
### Automatically Resolving Conflicts
58+
59+
There is a [useful script](https://github.com/getsentry/sentry/blob/master/bin/update-migration) for automatically moving your migration to the top of the migration history.
60+
61+
```bash
62+
bin/update-migration <migration_name>
63+
```
64+
65+
It will rename the migration, modify it to depend on the latest migration, and update the lockfile and the name of any tests if they exist.
66+
67+
### Manually Resolving Conflicts
68+
69+
To perform the steps manually, rebase against latest master, delete your current migration and then regenerate it. If your migration was custom, just save the operations in a text file somewhere so that you can reapply them on the regenerated migration.
5870

5971
Always commit the changes to `migrations_lockfile.txt` with your migration.
6072

develop-docs/backend/application-domains/email.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ Defaults to `(empty)`.
7878
<dd><markdown>
7979
Declared in `config.yml`.
8080

81-
Should Sentry use SSL when connecting to the SMTP server?
81+
Should Sentry use SSL when connecting to the SMTP server? Mutually exclusive with `mail.use-tls`.
8282

8383
Defaults to `false`.
8484

@@ -88,7 +88,7 @@ Defaults to `false`.
8888
<dd><markdown>
8989
Declared in `config.yml`.
9090

91-
Should Sentry use TLS when connecting to the SMTP server?
91+
Should Sentry use STARTTLS when connecting to the SMTP server? Mutually exclusive with `mail.use-ssl`.
9292

9393
Defaults to `false`.
9494

develop-docs/backend/application-domains/feature-flags/flagpole.mdx

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,10 @@ Here are some common properties we surface via our Sentry and GetSentry context
148148

149149
: The project's slug
150150

151+
`project_platform` [str]
152+
153+
: The project's platform
154+
151155
**User Context Properties (If checking a flag with an actor)**
152156

153157
`user_id` [int]
@@ -158,6 +162,18 @@ Here are some common properties we surface via our Sentry and GetSentry context
158162

159163
: The active user's email address. This should only contain Sentry employee email addresses.
160164

165+
`user_domain` [str]
166+
167+
: The domain of the active user's email address.
168+
169+
`user_is-staff` [bool]
170+
171+
: Is set to `true` for users that have `is_staff`.
172+
173+
`user_is-superuser` [bool]
174+
175+
: Is set to `true` for users that have `is_superuser`.
176+
161177

162178
To see the latest context properties available, check out the repo-specific context builders:
163179

develop-docs/backend/issue-platform/index.mdx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,6 @@ The issue platform provides functionality to help release your new issue type in
184184
- Post processing - This controls whether we'll pass the issue along to post processing. If disabled, then issues will be created but no notifications will be sent. This can be helpful for testing out what issues look like before release. _Note:_ Any issues created this way will not send new issue notifications after the flag is enabled, since they already exist. In the future, if there is demand we might provide a way to remove all test versions of a new issue type.
185185
- UI - This controls whether the issue type will appear in the issue list and elsewhere in the ui.
186186

187-
The flags for ingest and post processing are backed by options, and we automatically register these when the issue type is created. These options can be enabled for LA/EA/GA here
188-
https://sentry.io/_admin/options/.
189-
190-
The flag for the UI uses flagr. We're unable to register new flags in flagr automatically, so you'll need to create the flag in flagr yourself. The name will be in the format `organizations:<GroupType.slug.replace("_", "-")>-visible`.
187+
These flags are all controlled via flagpole and set via options automator. To get the base values for all of these for easy pasting into flagpole, run `sentry createissueflag --slug=<your_group_slug> --owner=<your_team_name>`. The results of this can be directly pasted into flagpole.yml.
191188

192189
Once your issue type is fully released, and you want it to go out to self-hosted and single tenant you can set `released = True` on your GroupType. This allows it to be released everywhere, and removes the feature flags and options. Generally we recommend doing this after your issue type has been in GA for long enough to verify that it's working as intended.

0 commit comments

Comments
 (0)