Skip to content

Conversation

stefanosiano
Copy link
Member

📜 Description

reduced bitmap size and background worker count in ProfilingSampleActivity to reduce the likeliness of ANRs during tests

#skip-changelog

💡 Motivation and Context

Sometimes a test was failing, likely due to an ANR

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…ivity to reduce the likeliness of ANRs during tests
@stefanosiano stefanosiano marked this pull request as ready for review January 12, 2024 15:39
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 465.30 ms 533.52 ms 68.22 ms
Size 1.70 MiB 2.27 MiB 582.25 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4e29063 376.38 ms 390.98 ms 14.60 ms
d429384 393.79 ms 454.64 ms 60.85 ms
2a3dd50 363.61 ms 440.18 ms 76.57 ms
93a76ca 377.41 ms 448.22 ms 70.81 ms
937879e 417.64 ms 550.45 ms 132.81 ms
606074f 385.10 ms 428.24 ms 43.14 ms
3d8bd2b 375.34 ms 446.32 ms 70.98 ms
8fd337b 349.16 ms 459.22 ms 110.06 ms
0810952 364.51 ms 468.08 ms 103.57 ms
b172d4e 412.60 ms 492.68 ms 80.08 ms

App size

Revision Plain With Sentry Diff
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
d429384 1.72 MiB 2.27 MiB 558.42 KiB
2a3dd50 1.72 MiB 2.27 MiB 555.05 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
937879e 1.72 MiB 2.27 MiB 558.42 KiB
606074f 1.70 MiB 2.27 MiB 582.26 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB
8fd337b 1.72 MiB 2.27 MiB 555.00 KiB
0810952 1.72 MiB 2.27 MiB 558.21 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@stefanosiano stefanosiano merged commit c554ca2 into main Jan 12, 2024
@stefanosiano stefanosiano deleted the fix/reduce-ui-test-activity-load branch January 12, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants