Skip to content

Commit 2891b58

Browse files
committed
fix(span): align span operations to new operations
Signed-off-by: Outsider <[email protected]>
1 parent 28c464d commit 2891b58

File tree

25 files changed

+61
-61
lines changed

25 files changed

+61
-61
lines changed

packages/ember/addon/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export const instrumentRoutePerformance = (BaseRoute: any) => {
8484
[BaseRoute.name]: class extends BaseRoute {
8585
beforeModel(...args: any[]) {
8686
return instrumentFunction(
87-
'ember.route.beforeModel',
87+
'ui.ember.route.before_model',
8888
(<any>this).fullRouteName,
8989
super.beforeModel.bind(this),
9090
args,
@@ -97,7 +97,7 @@ export const instrumentRoutePerformance = (BaseRoute: any) => {
9797

9898
async afterModel(...args: any[]) {
9999
return instrumentFunction(
100-
'ember.route.afterModel',
100+
'ui.ember.route.after_model',
101101
(<any>this).fullRouteName,
102102
super.afterModel.bind(this),
103103
args,
@@ -106,7 +106,7 @@ export const instrumentRoutePerformance = (BaseRoute: any) => {
106106

107107
async setupController(...args: any[]) {
108108
return instrumentFunction(
109-
'ember.route.setupController',
109+
'ui.ember.route.setup_controller',
110110
(<any>this).fullRouteName,
111111
super.setupController.bind(this),
112112
args,

packages/ember/tests/acceptance/sentry-performance-test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ module('Acceptance | Sentry Transactions', function (hooks) {
9090
'ui.ember.transition | route:tracing -> route:slow-loading-route.index',
9191
'ui.ember.component.render | component:link-to',
9292
'ui.ember.component.render | component:link-to',
93-
'ember.route.beforeModel | slow-loading-route',
93+
'ui.ember.route.before_model | slow-loading-route',
9494
'ui.ember.runloop.actions | undefined',
9595
'ui.ember.runloop.routerTransitions | undefined',
9696
'ui.ember.runloop.render | undefined',
@@ -102,15 +102,15 @@ module('Acceptance | Sentry Transactions', function (hooks) {
102102
'ui.ember.runloop.render | undefined',
103103
'ui.ember.runloop.afterRender | undefined',
104104
'ui.ember.runloop.destroy | undefined',
105-
'ember.route.afterModel | slow-loading-route',
105+
'ui.ember.route.after_model | slow-loading-route',
106106
'ui.ember.runloop.actions | undefined',
107107
'ui.ember.runloop.routerTransitions | undefined',
108108
'ui.ember.component.render | component:link-to',
109109
'ui.ember.component.render | component:link-to',
110110
'ui.ember.runloop.render | undefined',
111111
'ui.ember.runloop.afterRender | undefined',
112112
'ui.ember.runloop.destroy | undefined',
113-
'ember.route.beforeModel | slow-loading-route.index',
113+
'ui.ember.route.before_model | slow-loading-route.index',
114114
'ui.ember.runloop.actions | undefined',
115115
'ui.ember.runloop.routerTransitions | undefined',
116116
'ui.ember.runloop.render | undefined',
@@ -122,10 +122,10 @@ module('Acceptance | Sentry Transactions', function (hooks) {
122122
'ui.ember.runloop.render | undefined',
123123
'ui.ember.runloop.afterRender | undefined',
124124
'ui.ember.runloop.destroy | undefined',
125-
'ember.route.afterModel | slow-loading-route.index',
125+
'ui.ember.route.after_model | slow-loading-route.index',
126126
'ui.ember.runloop.actions | undefined',
127-
'ember.route.setupController | slow-loading-route',
128-
'ember.route.setupController | slow-loading-route.index',
127+
'ui.ember.route.setup_controller | slow-loading-route',
128+
'ui.ember.route.setup_controller | slow-loading-route.index',
129129
'ui.ember.runloop.routerTransitions | undefined',
130130
'ui.ember.component.render | component:link-to',
131131
'ui.ember.component.render | component:link-to',

packages/remix/src/utils/instrumentServer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ function makeWrappedDocumentRequestFunction(
115115

116116
try {
117117
const span = activeTransaction?.startChild({
118-
op: 'remix.server.documentRequest',
118+
op: 'function.remix.document_request',
119119
description: activeTransaction.name,
120120
tags: {
121121
method: request.method,
@@ -147,7 +147,7 @@ function makeWrappedDataFunction(origFn: DataFunction, id: string, name: 'action
147147

148148
try {
149149
const span = activeTransaction?.startChild({
150-
op: `remix.server.${name}`,
150+
op: `function.remix.${name}`,
151151
description: id,
152152
tags: {
153153
name,

packages/serverless/src/awslambda.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ export function wrapHandler<TEvent, TResult>(
315315

316316
const transaction = hub.startTransaction({
317317
name: context.functionName,
318-
op: 'awslambda.handler',
318+
op: 'function.aws.lambda',
319319
...traceparentData,
320320
metadata: {
321321
dynamicSamplingContext: traceparentData && !dynamicSamplingContext ? {} : dynamicSamplingContext,

packages/serverless/src/awsservices.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ function wrapMakeRequest<TService extends AWSService, TResult>(
6565
if (transaction) {
6666
span = transaction.startChild({
6767
description: describe(this, operation, params),
68-
op: 'aws.request',
68+
op: 'http.client',
6969
});
7070
}
7171
});

packages/serverless/src/gcpfunction/cloud_events.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ function _wrapCloudEventFunction(
3434

3535
const transaction = hub.startTransaction({
3636
name: context.type || '<unknown>',
37-
op: 'gcp.function.cloud_event',
37+
op: 'function.gcp.cloud_event',
3838
metadata: { source: 'component' },
3939
});
4040

packages/serverless/src/gcpfunction/events.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function _wrapEventFunction<F extends EventFunction | EventFunctionWithCallback>
3636

3737
const transaction = hub.startTransaction({
3838
name: context.eventType,
39-
op: 'gcp.function.event',
39+
op: 'function.gcp.event',
4040
metadata: { source: 'component' },
4141
});
4242

packages/serverless/src/gcpfunction/http.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr
8585

8686
const transaction = hub.startTransaction({
8787
name: `${reqMethod} ${reqUrl}`,
88-
op: 'gcp.function.http',
88+
op: 'function.gcp.http',
8989
...traceparentData,
9090
metadata: {
9191
dynamicSamplingContext: traceparentData && !dynamicSamplingContext ? {} : dynamicSamplingContext,

packages/serverless/src/google-cloud-grpc.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ function fillGrpcFunction(stub: Stub, serviceIdentifier: string, methodName: str
114114
if (transaction) {
115115
span = transaction.startChild({
116116
description: `${callType} ${methodName}`,
117-
op: `gcloud.grpc.${serviceIdentifier}`,
117+
op: `grpc.${serviceIdentifier}`,
118118
});
119119
}
120120
ret.on('status', () => {

packages/serverless/src/google-cloud-http.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ function wrapRequestFunction(orig: RequestFunction): RequestFunction {
5959
const httpMethod = reqOpts.method || 'GET';
6060
span = transaction.startChild({
6161
description: `${httpMethod} ${reqOpts.uri}`,
62-
op: `gcloud.http.${identifyService(this.apiEndpoint)}`,
62+
op: `http.client.${identifyService(this.apiEndpoint)}`,
6363
});
6464
}
6565
orig.call(this, reqOpts, (...args: Parameters<ResponseCallback>) => {

0 commit comments

Comments
 (0)