From 35aba05fb725def7e4212dc929c22167f8f99416 Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Thu, 23 Jan 2025 11:45:17 +0100 Subject: [PATCH 1/3] fix: don't log on windows-powershell if debug=false --- modules/Sentry/private/DiagnosticLogger.ps1 | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/modules/Sentry/private/DiagnosticLogger.ps1 b/modules/Sentry/private/DiagnosticLogger.ps1 index 3732b3e..ab4efc7 100644 --- a/modules/Sentry/private/DiagnosticLogger.ps1 +++ b/modules/Sentry/private/DiagnosticLogger.ps1 @@ -53,7 +53,12 @@ class DiagnosticLogger : Sentry.Extensibility.IDiagnosticLogger { # Workaround for Windows Powershell issue of halting and asking for user confirmation. # see https://github.com/PowerShell/PowerShell/issues/5148 - $DebugPreference = 'Continue' + if ($global:PSVersionTable.PSEdition -eq 'Desktop') { + $pref = Get-Variable DebugPreference + if ($pref.value -eq "Inquire") { + $DebugPreference = 'Continue' + } + } Write-Debug $message } From 168f2e7daa3f1f4b4714a4bf1fb888f99c10d43a Mon Sep 17 00:00:00 2001 From: Ivan Dlugos Date: Thu, 23 Jan 2025 11:46:31 +0100 Subject: [PATCH 2/3] chore: changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e39921f..b916c60 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### Fixes + +- Windows-Powershell logged debug messages even though -Debug wasn't set ([#75](https://github.com/getsentry/sentry-powershell/pull/75)) + ### Dependencies - Bump Dotnet SDK from v4.12.1 to v4.13.0 ([#69](https://github.com/getsentry/sentry-powershell/pull/69)) From e175eb2039be1305948517d911a20c9ea40e857d Mon Sep 17 00:00:00 2001 From: Ivan Dlugos <6349682+vaind@users.noreply.github.com> Date: Thu, 23 Jan 2025 11:55:02 +0100 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b916c60..8fa4067 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ ### Fixes -- Windows-Powershell logged debug messages even though -Debug wasn't set ([#75](https://github.com/getsentry/sentry-powershell/pull/75)) +- Don't log debug messages if `-Debug` wasn't set ([#75](https://github.com/getsentry/sentry-powershell/pull/75)) ### Dependencies