From 8e0040cbbf3730ef9ffd45e6667653c1ba1c6a76 Mon Sep 17 00:00:00 2001
From: Daniel Szoke <daniel.szoke@sentry.io>
Date: Wed, 10 Jul 2024 18:46:46 +0200
Subject: [PATCH] ref(init): Move `sentry_sdk.init` out of `hub.py`

Now that the `Hub`-based API is deprecated, `sentry_sdk.init` should no longer be in `hub.py`. Since it is kind of its own thing, it makes sense to implement `init` in its own file.

Closes #3233
---
 sentry_sdk/__init__.py             |  3 +-
 sentry_sdk/_init_implementation.py | 63 ++++++++++++++++++++++++++++++
 sentry_sdk/hub.py                  | 58 ---------------------------
 3 files changed, 65 insertions(+), 59 deletions(-)
 create mode 100644 sentry_sdk/_init_implementation.py

diff --git a/sentry_sdk/__init__.py b/sentry_sdk/__init__.py
index 94d97a87d8..f74c20a194 100644
--- a/sentry_sdk/__init__.py
+++ b/sentry_sdk/__init__.py
@@ -1,7 +1,8 @@
-from sentry_sdk.hub import Hub, init
+from sentry_sdk.hub import Hub
 from sentry_sdk.scope import Scope
 from sentry_sdk.transport import Transport, HttpTransport
 from sentry_sdk.client import Client
+from sentry_sdk._init_implementation import init
 
 from sentry_sdk.api import *  # noqa
 
diff --git a/sentry_sdk/_init_implementation.py b/sentry_sdk/_init_implementation.py
new file mode 100644
index 0000000000..382b82acac
--- /dev/null
+++ b/sentry_sdk/_init_implementation.py
@@ -0,0 +1,63 @@
+from typing import TYPE_CHECKING
+
+import sentry_sdk
+
+if TYPE_CHECKING:
+    from typing import Any, ContextManager, Optional
+
+    import sentry_sdk.consts
+
+
+class _InitGuard:
+    def __init__(self, client):
+        # type: (sentry_sdk.Client) -> None
+        self._client = client
+
+    def __enter__(self):
+        # type: () -> _InitGuard
+        return self
+
+    def __exit__(self, exc_type, exc_value, tb):
+        # type: (Any, Any, Any) -> None
+        c = self._client
+        if c is not None:
+            c.close()
+
+
+def _check_python_deprecations():
+    # type: () -> None
+    # Since we're likely to deprecate Python versions in the future, I'm keeping
+    # this handy function around. Use this to detect the Python version used and
+    # to output logger.warning()s if it's deprecated.
+    pass
+
+
+def _init(*args, **kwargs):
+    # type: (*Optional[str], **Any) -> ContextManager[Any]
+    """Initializes the SDK and optionally integrations.
+
+    This takes the same arguments as the client constructor.
+    """
+    client = sentry_sdk.Client(*args, **kwargs)
+    sentry_sdk.Scope.get_global_scope().set_client(client)
+    _check_python_deprecations()
+    rv = _InitGuard(client)
+    return rv
+
+
+if TYPE_CHECKING:
+    # Make mypy, PyCharm and other static analyzers think `init` is a type to
+    # have nicer autocompletion for params.
+    #
+    # Use `ClientConstructor` to define the argument types of `init` and
+    # `ContextManager[Any]` to tell static analyzers about the return type.
+
+    class init(sentry_sdk.consts.ClientConstructor, _InitGuard):  # noqa: N801
+        pass
+
+else:
+    # Alias `init` for actual usage. Go through the lambda indirection to throw
+    # PyCharm off of the weakly typed signature (it would otherwise discover
+    # both the weakly typed signature of `_init` and our faked `init` type).
+
+    init = (lambda: _init)()
diff --git a/sentry_sdk/hub.py b/sentry_sdk/hub.py
index 81abff8b5c..47975eee80 100644
--- a/sentry_sdk/hub.py
+++ b/sentry_sdk/hub.py
@@ -44,7 +44,6 @@
         LogLevelStr,
         SamplingContext,
     )
-    from sentry_sdk.consts import ClientConstructor
     from sentry_sdk.tracing import TransactionKwargs
 
     T = TypeVar("T")
@@ -59,63 +58,6 @@ def overload(x):
 _local = ContextVar("sentry_current_hub")
 
 
-class _InitGuard:
-    def __init__(self, client):
-        # type: (Client) -> None
-        self._client = client
-
-    def __enter__(self):
-        # type: () -> _InitGuard
-        return self
-
-    def __exit__(self, exc_type, exc_value, tb):
-        # type: (Any, Any, Any) -> None
-        c = self._client
-        if c is not None:
-            c.close()
-
-
-def _check_python_deprecations():
-    # type: () -> None
-    # Since we're likely to deprecate Python versions in the future, I'm keeping
-    # this handy function around. Use this to detect the Python version used and
-    # to output logger.warning()s if it's deprecated.
-    pass
-
-
-def _init(*args, **kwargs):
-    # type: (*Optional[str], **Any) -> ContextManager[Any]
-    """Initializes the SDK and optionally integrations.
-
-    This takes the same arguments as the client constructor.
-    """
-    client = Client(*args, **kwargs)
-    Scope.get_global_scope().set_client(client)
-    _check_python_deprecations()
-    rv = _InitGuard(client)
-    return rv
-
-
-from sentry_sdk._types import TYPE_CHECKING
-
-if TYPE_CHECKING:
-    # Make mypy, PyCharm and other static analyzers think `init` is a type to
-    # have nicer autocompletion for params.
-    #
-    # Use `ClientConstructor` to define the argument types of `init` and
-    # `ContextManager[Any]` to tell static analyzers about the return type.
-
-    class init(ClientConstructor, _InitGuard):  # noqa: N801
-        pass
-
-else:
-    # Alias `init` for actual usage. Go through the lambda indirection to throw
-    # PyCharm off of the weakly typed signature (it would otherwise discover
-    # both the weakly typed signature of `_init` and our faked `init` type).
-
-    init = (lambda: _init)()
-
-
 class HubMeta(type):
     @property
     def current(cls):