refine type of special fields

Author: dashed

src/sentry/static/sentry/app/views/organizationEventsV2/data.tsx

@@ -100,15 +100,15 @@ type RenderFunctionBaggage = {
   location: ReactRouterLocation;
 };
 
-type RenderFunction = (
+type FieldFormatterRenderFunction = (
   field: string,
   data: EventData,
   baggage: RenderFunctionBaggage
 ) => React.ReactNode;
 
 type FieldFormatter = {
   sortField: boolean;
-  renderFunc: RenderFunction;
+  renderFunc: FieldFormatterRenderFunction;
 };
 
 type FieldFormatters = {
@@ -185,14 +185,34 @@ export const FIELD_FORMATTERS: FieldFormatters = {
   },
 };
 
+type SpecialFieldRenderFunc = (
+  data: EventData,
+  baggage: RenderFunctionBaggage
+) => React.ReactNode;
+
+type SpecialField = {
+  sortField: boolean;
+  renderFunc: SpecialFieldRenderFunc;
+};
+
+type SpecialFields = {
+  transaction: SpecialField;
+  title: SpecialField;
+  type: SpecialField;
+  project: SpecialField;
+  user: SpecialField;
+  issue_title: SpecialField;
+  last_seen: SpecialField;
+};
+
 /**
  * "Special fields" do not map 1:1 to an single column in the event database,
  * they are a UI concept that combines the results of multiple fields and
  * displays with a custom render function.
  */
-export const SPECIAL_FIELDS = {
+export const SPECIAL_FIELDS: SpecialFields = {
   transaction: {
-    sortField: 'transaction',
+    sortField: true,
     renderFunc: (data, {location}) => {
       const target = {
         pathname: location.pathname,
@@ -211,7 +231,7 @@ export const SPECIAL_FIELDS = {
     },
   },
   title: {
-    sortField: 'title',
+    sortField: true,
     renderFunc: (data, {location}) => {
       const target = {
         pathname: location.pathname,
@@ -227,7 +247,7 @@ export const SPECIAL_FIELDS = {
     },
   },
   type: {
-    sortField: 'event.type',
+    sortField: true,
     renderFunc: (data, {location}) => {
       const target = {
         pathname: location.pathname,
@@ -256,7 +276,7 @@ export const SPECIAL_FIELDS = {
     },
   },
   user: {
-    sortField: 'user.id',
+    sortField: true,
     renderFunc: (data, {location}) => {
       const userObj = {
         id: data['user.id'],
@@ -286,7 +306,7 @@ export const SPECIAL_FIELDS = {
     },
   },
   issue_title: {
-    sortField: 'issue_title',
+    sortField: true,
     renderFunc: (data, {location}) => {
       const target = {
         pathname: location.pathname,
@@ -305,7 +325,7 @@ export const SPECIAL_FIELDS = {
     },
   },
   last_seen: {
-    sortField: 'last_seen',
+    sortField: true,
     renderFunc: data => {
       return (
         <Container>

src/sentry/static/sentry/app/views/organizationEventsV2/table.tsx

@@ -74,7 +74,9 @@ export default class Table extends React.Component<Props> {
 
             let sortKey: string | null = field;
             if (SPECIAL_FIELDS.hasOwnProperty(field)) {
-              sortKey = SPECIAL_FIELDS[field].sortField ? field : null;
+              sortKey = SPECIAL_FIELDS[field as keyof typeof SPECIAL_FIELDS].sortField
+                ? field
+                : null;
             } else if (FIELD_FORMATTERS.hasOwnProperty(field)) {
               sortKey = FIELD_FORMATTERS[field as keyof typeof FIELD_FORMATTERS].sortField
                 ? field