feat(dashboards): Add a confirm on dashboard deletion (#29971)

* feat(dashboards): Add a confirm on dashboard deletion

- Show a message to confirm that deletion is desired on the dashboard
  management page

* fix: tests

Author: wmak

static/app/views/dashboardsV2/manage/dashboardList.tsx

@@ -17,6 +17,7 @@ import {
 } from 'app/actionCreators/dashboards';
 import {addErrorMessage, addSuccessMessage} from 'app/actionCreators/indicator';
 import {Client} from 'app/api';
+import {openConfirmModal} from 'app/components/confirm';
 import EmptyStateWarning from 'app/components/emptyStateWarning';
 import MenuItem from 'app/components/menuItem';
 import Pagination from 'app/components/pagination';
@@ -141,11 +142,15 @@ function DashboardList({
             <ContextMenu>
               <MenuItem
                 data-test-id="dashboard-delete"
+                disabled={dashboards.length <= 1}
                 onClick={event => {
                   event.preventDefault();
-                  handleDelete(dashboard);
+                  openConfirmModal({
+                    message: t('Are you sure you want to delete this dashboard?'),
+                    priority: 'danger',
+                    onConfirm: () => handleDelete(dashboard),
+                  });
                 }}
-                disabled={dashboards.length <= 1}
               >
                 {t('Delete')}
               </MenuItem>

tests/js/spec/views/dashboardsV2/manage/dashboardList.spec.jsx

@@ -1,4 +1,5 @@
 import {mountWithTheme} from 'sentry-test/enzyme';
+import {mountGlobalModal} from 'sentry-test/modal';
 
 import DashboardList from 'app/views/dashboardsV2/manage/dashboardList';
 
@@ -192,6 +193,12 @@ describe('Dashboards > DashboardList', function () {
     card = wrapper.find('DashboardCard').last();
     clickMenuItem(card, 'dashboard-delete');
 
+    expect(deleteMock).not.toHaveBeenCalled();
+
+    // Confirm
+    const modal = await mountGlobalModal();
+    modal.find('Button').last().simulate('click');
+
     await tick();
 
     expect(deleteMock).toHaveBeenCalled();