Skip to content

Commit 74a5f38

Browse files
feat(perf-issue): differentiate snuba referrer on group_type (#39796)
Modify the referrer when we query for Group Events.
1 parent 1e35b75 commit 74a5f38

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/sentry/api/endpoints/group_events.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,11 @@ def _get_events_snuba(
8585
"start": start if start else default_start,
8686
"end": end if end else default_end,
8787
}
88-
direct_hit_resp = get_direct_hit_response(request, query, params, "api.group-events", group)
88+
referrer = f"api.group-events.{group.issue_category.name.lower()}"
89+
90+
direct_hit_resp = get_direct_hit_response(
91+
request, query, params, f"{referrer}.direct-hit", group
92+
)
8993
if direct_hit_resp:
9094
return direct_hit_resp
9195

@@ -102,7 +106,7 @@ def _get_events_snuba(
102106
full = request.GET.get("full", False)
103107
data_fn = partial(
104108
eventstore.get_events if full else eventstore.get_unfetched_events,
105-
referrer="api.group-events",
109+
referrer=referrer,
106110
filter=snuba_filter,
107111
dataset=dataset,
108112
)

src/sentry/snuba/referrer.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ class Referrer(Enum):
4040
API_EVENTS_VITALS = "api.events.vitals"
4141
API_GROUP_HASHES_LEVELS_GET_LEVEL_NEW_ISSUES = "api.group_hashes_levels.get_level_new_issues"
4242
API_GROUP_HASHES_LEVELS_GET_LEVELS_OVERVIEW = "api.group_hashes_levels.get_levels_overview"
43-
API_GROUP_EVENTS = "api.group-events"
43+
API_GROUP_EVENTS_ERROR = "api.group-events.error"
44+
API_GROUP_EVENTS_PERFORMANCE = "api.group-events.performance"
45+
API_GROUP_EVENTS_ERROR_DIRECT_HIT = "api.group-events.error.direct-hit"
46+
API_GROUP_EVENTS_PERFORMANCE_DIRECT_HIT = "api.group-events.performance.direct-hit"
4447
API_GROUP_HASHES = "api.group-hashes"
4548
API_ORGANIZATION_EVENT_STATS = "api.organization-event-stats"
4649
API_ORGANIZATION_EVENT_STATS_FIND_TOPN = "api.organization-event-stats.find-topn"

0 commit comments

Comments
 (0)