From eddbf93ca1c96886dedd3a5e02f8a26124269364 Mon Sep 17 00:00:00 2001 From: Lyn Nagara Date: Tue, 12 Nov 2019 15:56:42 -0800 Subject: [PATCH] ref: Remove "store.save-event-skips-nodestore" option from code This was a temporary option that has now been set to True in production. --- src/sentry/event_manager.py | 5 ++--- src/sentry/models/event.py | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/sentry/event_manager.py b/src/sentry/event_manager.py index a5a3b27a7bd0cf..67bac27deceacf 100644 --- a/src/sentry/event_manager.py +++ b/src/sentry/event_manager.py @@ -15,7 +15,7 @@ from django.utils import timezone from django.utils.encoding import force_text -from sentry import buffer, eventtypes, eventstream, options, tsdb +from sentry import buffer, eventtypes, eventstream, tsdb from sentry.constants import ( DEFAULT_STORE_NORMALIZER_ARGS, LOG_LEVELS, @@ -722,8 +722,7 @@ def save(self, project_id, raw=False, assume_normalized=False): # save the event try: with transaction.atomic(using=router.db_for_write(Event)): - if options.get("store.save-event-skips-nodestore", True): - event.data.save() + event.data.save() event.save() except IntegrityError: logger.info( diff --git a/src/sentry/models/event.py b/src/sentry/models/event.py index c83d565810aaf8..011880e9fa5b32 100644 --- a/src/sentry/models/event.py +++ b/src/sentry/models/event.py @@ -14,7 +14,7 @@ from semaphore.processing import StoreNormalizer -from sentry import eventtypes, options +from sentry import eventtypes from sentry.db.models import ( BoundedBigIntegerField, BoundedIntegerField, @@ -619,7 +619,7 @@ class Event(EventCommon, Model): ref_func=lambda x: x.project_id or x.project.id, ref_version=2, wrapper=EventDict, - skip_nodestore_save=options.get("store.save-event-skips-nodestore", True), + skip_nodestore_save=True, ) objects = EventManager()