double check swa

ngxson · ngxson · commit 2913e5ff1ef2 · 2024-08-10T11:24:50.000+02:00
diff --git a/src/llama.cpp b/src/llama.cpp
@@ -4912,7 +4912,10 @@ static void llm_load_hparams(
                     // default value for Phi-3-medium-128k-instruct
                     hparams.n_swa = 131072;
                 }
-                ml.get_key(LLM_KV_ATTENTION_SLIDING_WINDOW, hparams.n_swa, false);
+                bool found_swa = ml.get_key(LLM_KV_ATTENTION_SLIDING_WINDOW, hparams.n_swa, false);
+                if (!found_swa && hparams.n_swa == 0) {
+                    throw std::runtime_error("invalid value for sliding_window");
+                }
             } break;
         case LLM_ARCH_PLAMO:
             {

Original file line number	Diff line number	Diff line change
`@@ -4912,7 +4912,10 @@ static void llm_load_hparams(`
`4912`	`4912`	`// default value for Phi-3-medium-128k-instruct`
`4913`	`4913`	`hparams.n_swa = 131072;`
`4914`	`4914`	`}`
`4915`		`- ml.get_key(LLM_KV_ATTENTION_SLIDING_WINDOW, hparams.n_swa, false);`
	`4915`	`+ bool found_swa = ml.get_key(LLM_KV_ATTENTION_SLIDING_WINDOW, hparams.n_swa, false);`
	`4916`	`+ if (!found_swa && hparams.n_swa == 0) {`
	`4917`	`+ throw std::runtime_error("invalid value for sliding_window");`
	`4918`	`+ }`
`4916`	`4919`	`} break;`
`4917`	`4920`	`case LLM_ARCH_PLAMO:`
`4918`	`4921`	`{`