Skip to content

Some bugs in new server UI (pr #4236) #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mounta11n opened this issue Dec 21, 2023 · 2 comments
Closed

Some bugs in new server UI (pr #4236) #4557

mounta11n opened this issue Dec 21, 2023 · 2 comments

Comments

@mounta11n
Copy link
Contributor

mounta11n commented Dec 21, 2023

The following errors relate to my pull request #4236

Expected Behavior

The following behaviors are expected:

  • Regardless of whether you are using Chat or Completion, as soon as you are finished and click on the 'back' button, the toggle button in the top left should display the current state.

  • Likewise, when you click on the 'back' button, the total tokens counter should reset to zero.

  • If you switch from the old UI to the new UI, the corresponding default values should be updated and vice versa.

  • The color themes should be consistent, regardless of the dark/light setting of the operating system.

Current Behavior

Current observed behavior:

  • If you are in completion mode and then click on back, the completion form is still displayed correctly, but the toggle button now incorrectly displays 'chat'.

  • Likewise, if you click on the 'back' button, the total tokens counter still shows the last value and continues to accumulate as you start more chat sessions.
    -> Only a manual refresh in the browser resets the counter.

  • If you switch from the old UI to the new UI, the standard values of the old UI are still displayed.
    -> Only when the reset button is pressed will the corresponding valid values be adopted.

  • The text fields all turn dark when the operating system is in dark mode, which is not the desired color and behavior.

Environment and Context

I have tested the new UI on

  • macOS 13.6.1 with Safari 17.1.2 and Firefox 120.0.1
  • Pop!_OS with Firefox 119.0.1

Miscellaneous

As I said before, the bugs do not affect the current frontend, but a new one, which can be found in my following PR #4236

The latest commit at this time is:

2017112

However, I accidentally made a mess, which is why over 100 changed files are now incorrectly shown. However, it only affects files within the examples/server/public directory and specifically the index-new.html file.


I know that these are probably straightforward bugs, but I would still be very grateful for any help. Firstly, I think that an experienced developer in javascript can certainly fix these bugs much faster than I can and secondly, I have very limited time at the moment due to private and job commitments, but I think it would be very nice if the new UI could be merged before Christmas.

Below are some images showing the described errors


Safari-231221024326


iScreen Shoter - Safari - 231221024411


Safari-231221032155


Safari-231221032351

Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Mar 18, 2024
Copy link
Contributor

github-actions bot commented Apr 2, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant