Skip to content

Failing to convert the new PHI-3 models. #8259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
0wwafa opened this issue Jul 2, 2024 · 5 comments
Closed

Failing to convert the new PHI-3 models. #8259

0wwafa opened this issue Jul 2, 2024 · 5 comments
Labels
duplicate This issue or pull request already exists

Comments

@0wwafa
Copy link

0wwafa commented Jul 2, 2024

INFO:hf-to-gguf:Loading model: Phi-3-mini-128k-instruct
INFO:gguf.gguf_writer:gguf: This GGUF file is for Little Endian only
INFO:hf-to-gguf:Set model parameters
Traceback (most recent call last):
  File "/content/llama.cpp/convert-hf-to-gguf.py", line 3263, in <module>
    main()
  File "/content/llama.cpp/convert-hf-to-gguf.py", line 3244, in main
    model_instance.set_gguf_parameters()
  File "/content/llama.cpp/convert-hf-to-gguf.py", line 1950, in set_gguf_parameters
    raise NotImplementedError(f'The rope scaling type {rope_scaling_type} is not supported yet')
NotImplementedError: The rope scaling type longrope is not supported yet
@duynt575
Copy link

duynt575 commented Jul 2, 2024

The output clearly stated 'not supported yet', you should stop submitting issue every time.

@0wwafa
Copy link
Author

0wwafa commented Jul 3, 2024

well, I think phi-3 models deserve to be supported in full. they are smashing the leaderboard at the moment...

@duynt575
Copy link

duynt575 commented Jul 3, 2024

If you really think that then fork the repo and do it yourself. Stop demanding ffs!

@HanClinto
Copy link
Collaborator

Relevant work on phi3 is being done in a few different places, but perhaps most centrally in #7705 if you're looking for a place to jump in.

Thank you!

@HanClinto
Copy link
Collaborator

HanClinto commented Jul 3, 2024

Duplicate of #8241, #7922, #6849. Please refer to #6849, #7705 or #8031 to contribute. Opening new and intentionally duplicate issues is only fragmenting the discussion.

Thank you.

@HanClinto HanClinto closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2024
@HanClinto HanClinto added the duplicate This issue or pull request already exists label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants