Skip to content

Commit cb2490d

Browse files
committed
#754: Fix an issue where empty git.properties had been generated in submodules when injectAllReactorProjects=true
1 parent 38b9b4e commit cb2490d

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/main/java/pl/project13/maven/git/GitCommitIdMojo.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1145,6 +1145,7 @@ public void error(String msg, Throwable t) {
11451145
|| PropertiesFileGenerator.craftPropertiesOutputFile(
11461146
project.getBasedir(), new File(generateGitPropertiesFilename))
11471147
.exists()) {
1148+
log.info("Skip mojo execution on incremental builds.");
11481149
return;
11491150
}
11501151
}
@@ -1237,7 +1238,8 @@ public void error(String msg, Throwable t) {
12371238
log.info(
12381239
"injectAllReactorProjects is enabled - attempting to use the already computed values");
12391240
// makes sure the existing context properties are not mutated
1240-
properties = new Properties(contextProperties);
1241+
properties = new Properties();
1242+
properties.putAll(contextProperties);
12411243
}
12421244

12431245
final GitCommitIdPlugin.Callback cb =
@@ -1484,14 +1486,16 @@ private void publishPropertiesInto(Properties propertiesToPublish, Properties pr
14841486

14851487
private void appendPropertiesToReactorProjects(LogInterface log, Properties propertiesToPublish) {
14861488
for (MavenProject mavenProject : reactorProjects) {
1487-
log.debug("Adding properties to project: '" + mavenProject.getName() + "'");
1489+
log.debug("Adding '" + propertiesToPublish.size() + "' properties to project: '" + mavenProject.getName() + "'");
14881490
if (mavenProject.equals(project)) {
14891491
continue;
14901492
}
14911493
publishPropertiesInto(propertiesToPublish, mavenProject.getProperties());
14921494
mavenProject.setContextValue(CONTEXT_KEY, propertiesToPublish);
14931495
}
1494-
log.info("Added properties to '" + reactorProjects.size() + "' projects");
1496+
log.info(
1497+
"Added '" + propertiesToPublish.size() + "' properties " +
1498+
"to '" + reactorProjects.size() + "' projects");
14951499
}
14961500

14971501
private void logProperties(LogInterface log, Properties propertiesToPublish) {

0 commit comments

Comments
 (0)