Skip to content

Commit c757f9f

Browse files
Apply suggestions from code review
Co-authored-by: Henry Mercer <[email protected]>
1 parent 7898bc2 commit c757f9f

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/pr-checks.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ jobs:
117117
118118
check-node-version:
119119
if: ${{ github.event.pull_request }}
120-
name: Check node version consistency
120+
name: Check Action Node versions
121121
runs-on: ubuntu-latest
122122
timeout-minutes: 45
123123
env:
@@ -126,24 +126,24 @@ jobs:
126126
steps:
127127
- uses: actions/checkout@v4
128128
- id: head-version
129-
name: check HEAD node version
129+
name: Verify all Actions use the same Node version
130130
run: |
131131
NODE_VERSION=$(find . -name "action.yml" -exec yq -e '.runs.using' {} \; | grep node | sort | uniq)
132132
echo "NODE_VERSION: ${NODE_VERSION}"
133133
if [[ $(echo "$NODE_VERSION" | wc -l) -gt 1 ]]; then
134-
echo "Error: More than one node version used in actions."
134+
echo "::error::More than one node version used in 'action.yml' files."
135135
exit 1
136136
fi
137137
echo "node_version=${NODE_VERSION}" >> $GITHUB_OUTPUT
138138
139139
- id: checkout-base
140-
name: check out base ref for backport check
140+
name: 'Backport: Check out base ref'
141141
if: ${{ startsWith(github.head_ref, 'backport-') }}
142142
uses: actions/checkout@v4
143143
with:
144144
ref: ${{ env.BASE_REF }}
145145

146-
- name: compare with node version on base ref for backport check
146+
- name: 'Backport: Verify Node versions unchanged'
147147
if: steps.checkout-base.outcome == 'success'
148148
env:
149149
HEAD_VERSION: ${{ steps.head-version.outputs.node_version }}
@@ -152,6 +152,6 @@ jobs:
152152
echo "HEAD_VERSION: ${HEAD_VERSION}"
153153
echo "BASE_VERSION: ${BASE_VERSION}"
154154
if [[ "$BASE_VERSION" != "$HEAD_VERSION" ]]; then
155-
echo "Error: Cannot change node version in a backport PR."
155+
echo "::error::Cannot change the Node version of an Action in a backport PR."
156156
exit 1
157157
fi

0 commit comments

Comments
 (0)