File tree 1 file changed +7
-7
lines changed
shared/controlflow/codeql/controlflow
1 file changed +7
-7
lines changed Original file line number Diff line number Diff line change @@ -182,17 +182,17 @@ module Make<LocationSig Location, InputSig<Location> Input> {
182
182
bbIDominates ( this , succ ) and
183
183
// The above is not sufficient to ensure that `succ` can only be reached
184
184
// through `s`. To see why, consider this example corresponding to an
185
- // `if` expression without an `else` block:
185
+ // `if` statement without an `else` block and whe `A` is the basic block
186
+ // following the `if` statement:
186
187
// ```
187
- // ... --> cond --[true]--> ... --> if expr
188
+ // ... --> cond --[true]--> ... --> A
188
189
// \ /
189
190
// ----[false]-----------
190
191
// ```
191
- // The basic block for `cond` immediately dominates the directly
192
- // succeeding basic block for the `if` expression. But the `if`
193
- // expression is not immediately controlled by the `cond` basic block and
194
- // the `false` edge since it is also possible to reach the `if`
195
- // expression via the `true` edge.
192
+ // Here `A` is a direct successor of `cond` along the `false` edge and it
193
+ // is immediately dominated by `cond`, but `A` is not controlled by the
194
+ // `false` edge since it is also possible to reach `A` via the `true`
195
+ // edge.
196
196
//
197
197
// Note that the first and third conjunct implies the second. But
198
198
// explicitly including the second conjunct leads to a better join order.
You can’t perform that action at this time.
0 commit comments