Skip to content

Commit f5c176b

Browse files
yofftausbn
andauthored
Apply suggestions from code review
Co-authored-by: Taus <[email protected]>
1 parent e091ae8 commit f5c176b

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

python/ql/test/experimental/dataflow/strange-essaflow/testFlow.ql

-10
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,6 @@ private import semmle.python.dataflow.new.internal.DataFlowPrivate as DataFlowPr
44

55
/** Gets the EssaNode that holds the module imported by the fully qualified module name `name` */
66
DataFlow::CfgNode module_import(string name) {
7-
// exists(Variable var, Import imp, Alias alias |
8-
// alias = imp.getAName() and
9-
// alias.getAsname() = var.getAStore() and
10-
// (
11-
// name = alias.getValue().(ImportMember).getImportedModuleName()
12-
// or
13-
// name = alias.getValue().(ImportExpr).getImportedModuleName()
14-
// ) and
15-
// result.getVar().(AssignmentDefinition).getSourceVariable() = var
16-
// )
177
exists(Variable var, AssignmentDefinition def, Import imp, Alias alias |
188
var = def.getSourceVariable() and
199
result.getNode() = def.getDefiningNode() and

python/ql/test/experimental/dataflow/typetracking/tracked.ql

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ module TrackedTest implements TestSig {
2626
not e.getLocation().getStartLine() = 0 and
2727
// We do not wish to annotate scope entry definitions,
2828
// as they do not appear in the source code.
29-
// not e.asVar() instanceof ScopeEntryDefinition and
3029
not e.asCfgNode() = any(ScopeEntryDefinition def).getDefiningNode() and
3130
tag = "tracked" and
3231
location = e.getLocation() and

0 commit comments

Comments
 (0)