Dependabot Actions troubleshooting suggestions might be insecure #37658
Labels
content
This issue or pull request belongs to the Docs Content team
dependabot
Content related to Dependabot
needs SME
This proposal needs review from a subject matter expert
Code of Conduct
What article on docs.github.com is affected?
docs/data/reusables/dependabot/dependabot-on-actions-troubleshooting-workflows.md
Lines 7 to 8 in e2f952a
What part(s) of the article would you like to see updated?
if: github.actor != 'dependabot[bot]'
checkMaybe (at least for pull requests) it would be safer to use
github.event.pull_request.user.login != 'dependabot[bot]'
. Otherwise malicious users could abuse this to skip certain workflows, see related https://www.synacktiv.com/publications/github-actions-exploitation-dependabot.pull_request_target
and a "two-step process" without going into detail.It might be safer to not recommend
pull_request_target
(due to its inherent security risks), but rather suggest increasing thepermissions
and using Dependabot secrets (which is bullet point 3 of that recommendations list, so maybe this point 2 can simply be omitted?).Additional information
I am not completely sure about the proposed changes, so please let me know if I forget to consider something, or if something I wrote is incorrect.
The text was updated successfully, but these errors were encountered: