[installer]: move the post-processing of openvsx stateful sets into installer

Author: Simon Emms

install/installer/pkg/common/constants.go

@@ -40,6 +40,7 @@ const (
 	ServerComponent             = "server"
 	ServerInstallationAdminPort = 9000
 	SystemNodeCritical          = "system-node-critical"
+	OpenVSXProxyComponent       = "openvsx-proxy"
 	WSManagerComponent          = "ws-manager"
 	WSManagerBridgeComponent    = "ws-manager-bridge"
 	WSProxyComponent            = "ws-proxy"

install/installer/pkg/common/postprocess.go

@@ -12,6 +12,7 @@ import (
 	"github.com/mikefarah/yq/v4/pkg/yqlib"
 	logging "gopkg.in/op/go-logging.v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/utils/pointer"
 )
 
 // Processors list of processes executed on each resource document
@@ -21,6 +22,12 @@ var Processors = []Processor{
 		Type:       TypeMetaNetworkPolicy,
 		Expression: "del(.status)",
 	},
+	// Remove "status" from root of OpenVSXProxy stateful sets
+	{
+		Type:       TypeMetaStatefulSet,
+		Expression: "del(.status)",
+		Name:       pointer.String(OpenVSXProxyComponent),
+	},
 }
 
 type Processor struct {

install/installer/pkg/components/openvsx-proxy/constants.go

@@ -4,8 +4,10 @@
 
 package openvsx_proxy
 
+import "github.com/gitpod-io/gitpod/installer/pkg/common"
+
 const (
-	Component          = "openvsx-proxy"
+	Component          = common.OpenVSXProxyComponent
 	ContainerPort      = 8080
 	ServicePort        = 8080
 	PortName           = "http"

install/kots/manifests/gitpod-installer-job.yaml

@@ -311,12 +311,6 @@ spec:
               echo "Gitpod: render Kubernetes manifests"
               /app/installer render -c "${CONFIG_FILE}" --namespace {{repl Namespace }} --use-experimental-config > "${GITPOD_OBJECTS}/templates/gitpod.yaml"
 
-              # Workaround for #8532 and #8529
-              echo "Gitpod: Remove the StatefulSet status object for OpenVSX Proxy"
-              yq eval-all --inplace \
-                'del(select(.kind == "StatefulSet" and .metadata.name == "openvsx-proxy").status)' \
-                "${GITPOD_OBJECTS}/templates/gitpod.yaml"
-
               if [ '{{repl ConfigOptionEquals "reg_incluster" "1" }}' = "true" ];
               then
                 echo "Gitpod: Add the local registry secret to the in-cluster registry secret"