Skip to content

Commit 0b6c427

Browse files
akosyakovroboquat
authored andcommitted
[supervisor]: add ide-dekstop-ready phase to status_rendered analyitcs event
To track whether a user seen loading screen after configuring desktop IDE.
1 parent 234d579 commit 0b6c427

File tree

11 files changed

+425
-248
lines changed

11 files changed

+425
-248
lines changed

components/ide/code-desktop/status/main.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ func main() {
7373
response["link"] = link.String()
7474
response["label"] = label
7575
response["clientID"] = schema
76+
response["kind"] = "code-desktop"
7677
w.Header().Set("Content-Type", "application/json")
7778
json.NewEncoder(w).Encode(response)
7879
})

components/ide/jetbrains/image/status/main.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,15 @@ const defaultBackendPort = "63342"
2424

2525
// proxy for the Code With Me status endpoints that transforms it into the supervisor status format.
2626
func main() {
27-
if len(os.Args) < 2 {
28-
fmt.Printf("Usage: %s <port> [<link label>]\n", os.Args[0])
27+
if len(os.Args) < 3 {
28+
fmt.Printf("Usage: %s <port> <kind> [<link label>]\n", os.Args[0])
2929
os.Exit(1)
3030
}
3131
port := os.Args[1]
32+
kind := os.Args[2]
3233
label := "Open JetBrains IDE"
33-
if len(os.Args) > 2 {
34-
label = os.Args[2]
34+
if len(os.Args) > 3 {
35+
label = os.Args[3]
3536
}
3637

3738
errlog := log.New(os.Stderr, "JetBrains IDE status: ", log.LstdFlags)
@@ -77,6 +78,7 @@ func main() {
7778
response["link"] = gatewayLink
7879
response["label"] = label
7980
response["clientID"] = "jetbrains-gateway"
81+
response["kind"] = kind
8082
w.Header().Set("Content-Type", "application/json")
8183
_ = json.NewEncoder(w).Encode(response)
8284
})

components/ide/jetbrains/image/supervisor-ide-config_goland.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"entrypoint": "/ide-desktop/startup.sh",
3-
"entrypointArgs": [ "{DESKTOPIDEPORT}", "Open in GoLand" ],
3+
"entrypointArgs": [ "{DESKTOPIDEPORT}", "goland", "Open in GoLand" ],
44
"readinessProbe": {
55
"type": "http",
66
"http": {

components/ide/jetbrains/image/supervisor-ide-config_intellij.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"entrypoint": "/ide-desktop/startup.sh",
3-
"entrypointArgs": [ "{DESKTOPIDEPORT}", "Open in IntelliJ IDEA" ],
3+
"entrypointArgs": [ "{DESKTOPIDEPORT}", "intellij", "Open in IntelliJ IDEA" ],
44
"readinessProbe": {
55
"type": "http",
66
"http": {

components/ide/jetbrains/image/supervisor-ide-config_phpstorm.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"entrypoint": "/ide-desktop/startup.sh",
3-
"entrypointArgs": [ "{DESKTOPIDEPORT}", "Open in PhpStorm" ],
3+
"entrypointArgs": [ "{DESKTOPIDEPORT}", "phpstorm", "Open in PhpStorm" ],
44
"readinessProbe": {
55
"type": "http",
66
"http": {

components/ide/jetbrains/image/supervisor-ide-config_pycharm.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"entrypoint": "/ide-desktop/startup.sh",
3-
"entrypointArgs": [ "{DESKTOPIDEPORT}", "Open in PyCharm" ],
3+
"entrypointArgs": [ "{DESKTOPIDEPORT}", "pycharm", "Open in PyCharm" ],
44
"readinessProbe": {
55
"type": "http",
66
"http": {

components/supervisor-api/go/status.pb.go

Lines changed: 180 additions & 171 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)