[usage] Always set a CostCenter.nextBillingTime, even when we don't manage the billing

Author: jankeromnes

components/usage/pkg/db/cost_center.go

@@ -186,8 +186,8 @@ func (c *CostCenterManager) UpdateCostCenter(ctx context.Context, newCC CostCent
 			}
 
 			newCC.BillingCycleStart = common_db.NewVarCharTime(now)
-			// we don't manage stripe billing cycle
-			newCC.NextBillingTime = common_db.VarcharTime{}
+			// set an informative nextBillingTime, even though we don't manage Stripe billing cycle
+			newCC.NextBillingTime = common_db.NewVarCharTime(now.AddDate(0, 1, 0))
 		}
 	} else if isTeam {
 		// Billing strategy is Other, and it remains unchanged
@@ -214,8 +214,8 @@ func (c *CostCenterManager) UpdateCostCenter(ctx context.Context, newCC CostCent
 			}
 
 			newCC.BillingCycleStart = common_db.NewVarCharTime(now)
-			// we don't manage stripe billing cycle
-			newCC.NextBillingTime = common_db.VarcharTime{}
+			// set an informative nextBillingTime, even though we don't manage Stripe billing cycle
+			newCC.NextBillingTime = common_db.NewVarCharTime(now.AddDate(0, 1, 0))
 		}
 	} else {
 		return CostCenter{}, status.Errorf(codes.InvalidArgument, "Unknown attribution entity %s", string(attributionID))

components/usage/pkg/db/cost_center_test.go

@@ -289,7 +289,7 @@ func TestSaveCostCenterMovedToStripe(t *testing.T) {
 	teamCC, err = mnr.UpdateCostCenter(context.Background(), teamCC)
 	require.NoError(t, err)
 	require.Equal(t, db.CostCenter_Stripe, teamCC.BillingStrategy)
-	require.Equal(t, common_db.VarcharTime{}, teamCC.NextBillingTime)
+	require.Equal(t, teamCC.CreationTime.Time().AddDate(0, 1, 0), teamCC.NextBillingTime.Time())
 	require.Equal(t, int32(400050), teamCC.SpendingLimit)
 
 	teamCC.BillingStrategy = db.CostCenter_Other