Skip to content

Commit 0cf04fb

Browse files
Simon Emmsroboquat
Simon Emms
authored andcommitted
[kots]: put the HTTP Proxy settings behind a KOTS config bool
1 parent 22dec18 commit 0cf04fb

File tree

3 files changed

+14
-1
lines changed

3 files changed

+14
-1
lines changed

install/kots/manifests/gitpod-http-proxy-settings.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ metadata:
88
labels:
99
app: gitpod
1010
component: gitpod-installer
11+
annotations:
12+
kots.io/when: '{{repl ConfigOptionEquals "enable_proxy_settings" "1" }}'
1113
type: Opaque
1214
data:
1315
httpProxy: repl{{ HTTPProxy | Base64Encode | quote }}

install/kots/manifests/gitpod-kots-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ data:
2222
SSH_GATEWAY: repl{{ ConfigOption "ssh_gateway" | quote }}
2323

2424
# Secret names
25-
HTTP_PROXY_NAME: http-proxy-settings
25+
HTTP_PROXY_NAME: '{{repl if (ConfigOptionEquals "enable_proxy_settings" "1" ) }}http-proxy-settings{{repl end }}'
2626
LICENSE_NAME: gitpod-license
2727
SSH_GATEWAY_HOST_KEY_NAME: ssh-gateway-host-key
2828

install/kots/manifests/kots-config.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,3 +429,14 @@ spec:
429429
title: Cluster IP
430430
- name: NodePort
431431
title: Node port
432+
433+
- name: experimental
434+
title: Experimental options
435+
description: Experimental options without any support
436+
when: 'false'
437+
items:
438+
- name: enable_proxy_settings
439+
title: Enable proxy settings
440+
type: bool
441+
default: "0"
442+
help_text: Enable HTTP_PROXY support for the Gitpod application. This is currently an experimental feature.

0 commit comments

Comments
 (0)