Skip to content

Commit 0e4ccf1

Browse files
committed
Remove deprecated '#prebuild/' context URL prefix
1 parent 63d3b1a commit 0e4ccf1

File tree

4 files changed

+0
-57
lines changed

4 files changed

+0
-57
lines changed

components/gitpod-protocol/src/context-url.spec.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -41,24 +41,6 @@ export class ContextUrlTest {
4141
expect(actual?.pathname).to.equal("/gitpod-io/gitpod-test-repo.git");
4242
}
4343

44-
@test public parseContextUrl_withPrebuild() {
45-
const actual = ContextURL.getNormalizedURL({
46-
contextURL: "prebuild/https://github.com/gitpod-io/gitpod-test-repo",
47-
context: {},
48-
} as WsContextUrl);
49-
expect(actual?.host).to.equal("github.com");
50-
expect(actual?.pathname).to.equal("/gitpod-io/gitpod-test-repo");
51-
}
52-
53-
@test public parseContextUrl_withPrebuild_withoutSchema() {
54-
const actual = ContextURL.getNormalizedURL({
55-
contextURL: "prebuild/github.com/gitpod-io/gitpod-test-repo",
56-
context: {},
57-
} as WsContextUrl);
58-
expect(actual?.host).to.equal("github.com");
59-
expect(actual?.pathname).to.equal("/gitpod-io/gitpod-test-repo");
60-
}
61-
6244
@test public parseContextUrl_badUrl() {
6345
const actual = ContextURL.getNormalizedURL({ contextURL: "[Object object]", context: {} } as WsContextUrl);
6446
expect(actual).to.be.undefined;

components/gitpod-protocol/src/context-url.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ import { Workspace } from ".";
1515
* TODO(gpl) See if we can get this into `server` code to remove the burden from clients
1616
*/
1717
export namespace ContextURL {
18-
export const INCREMENTAL_PREBUILD_PREFIX = "incremental-prebuild";
19-
export const PREBUILD_PREFIX = "prebuild";
2018
export const IMAGEBUILD_PREFIX = "imagebuild";
2119
export const SNAPSHOT_PREFIX = "snapshot";
2220
export const REFERRER_PREFIX = "referrer:";
@@ -90,8 +88,6 @@ export namespace ContextURL {
9088

9189
const firstSegment = segments[0];
9290
if (
93-
firstSegment === PREBUILD_PREFIX ||
94-
firstSegment === INCREMENTAL_PREBUILD_PREFIX ||
9591
firstSegment === IMAGEBUILD_PREFIX ||
9692
firstSegment === SNAPSHOT_PREFIX ||
9793
firstSegment.startsWith(REFERRER_PREFIX)

components/server/ee/src/container-module.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ import { GitLabApp } from "./prebuilds/gitlab-app";
2323
import { BitbucketApp } from "./prebuilds/bitbucket-app";
2424
import { GitHubEnterpriseApp } from "./prebuilds/github-enterprise-app";
2525
import { IncrementalPrebuildsService } from "./prebuilds/incremental-prebuilds-service";
26-
import { IPrefixContextParser } from "../../src/workspace/context-parser";
27-
import { StartPrebuildContextParser } from "./prebuilds/start-prebuild-context-parser";
2826
import { WorkspaceFactory } from "../../src/workspace/workspace-factory";
2927
import { WorkspaceFactoryEE } from "./workspace/workspace-factory";
3028
import { MonitoringEndpointsAppEE } from "./monitoring-endpoint-ee";
@@ -72,7 +70,6 @@ export const productionEEContainerModule = new ContainerModule((bind, unbind, is
7270
rebind(MonitoringEndpointsApp).to(MonitoringEndpointsAppEE).inSingletonScope();
7371

7472
bind(PrebuildManager).toSelf().inSingletonScope();
75-
bind(IPrefixContextParser).to(StartPrebuildContextParser).inSingletonScope();
7673
bind(GithubApp).toSelf().inSingletonScope();
7774
bind(GitHubAppSupport).toSelf().inSingletonScope();
7875
bind(GithubAppRules).toSelf().inSingletonScope();

components/server/ee/src/prebuilds/start-prebuild-context-parser.ts

Lines changed: 0 additions & 32 deletions
This file was deleted.

0 commit comments

Comments
 (0)