[agent-smith] Fix proc stat

Author: csweichel

components/ee/agent-smith/pkg/detector/proc.go

@@ -109,6 +109,7 @@ func statProc(pid int) (*stat, error) {
 func parseStat(r io.Reader) (res *stat, err error) {
 	var (
 		ppid      uint64
+		foundPPID bool
 		starttime uint64
 		i         = -1
 	)
@@ -126,6 +127,7 @@ func parseStat(r io.Reader) (res *stat, err error) {
 
 		if i == 2 {
 			ppid, err = strconv.ParseUint(string(text), 10, 64)
+			foundPPID = true
 		}
 		if i == 20 {
 			starttime, err = strconv.ParseUint(string(text), 10, 64)
@@ -138,11 +140,14 @@ func parseStat(r io.Reader) (res *stat, err error) {
 			i++
 		}
 	}
+	if err != nil {
+		return nil, err
+	}
 	if err := scan.Err(); err != nil {
 		return nil, err
 	}
 
-	if ppid == 0 || starttime == 0 {
+	if !foundPPID || starttime == 0 {
 		return nil, fmt.Errorf("cannot parse stat")
 	}
 

components/ee/agent-smith/pkg/detector/proc_test.go

@@ -375,6 +375,16 @@ func TestParseStat(t *testing.T) {
 			Content:     "80275 (cat) R 717 80275 717 34817 80275 4194304 85 0 0 0 0 0 0 0 26 6 1 0 4733826 5771264 135 18446744073709551615 94070799228928 94070799254577 140722983793472 0 0 0 0 0 0 0 0 0 17 14 0 0 0 0 0 94070799272592 94070799274176 94070803738624 140722983801930 140722983801950 140722983801950 140722983821291 0",
 			Expectation: Expectation{S: &stat{PPID: 717, Starttime: 4733826}},
 		},
+		{
+			Name:        "pid 1",
+			Content:     "1 (systemd) S 0 1 1 0 -1 4194560 62769 924461 98 1590 388 255 2488 1097 20 0 1 0 63 175169536 3435 18446744073709551615 94093530578944 94093531561125 140726309452800 0 0 0 671173123 4096 1260 1 0 0 17 3 0 0 32 0 0 94093531915152 94093532201000 94093562523648 140726309453736 140726309453747 140726309453747 140726309453805 0",
+			Expectation: Expectation{S: &stat{Starttime: 63}},
+		},
+		{
+			Name:        "kthreadd",
+			Content:     "2 (kthreadd) S 0 0 0 0 -1 2129984 0 0 0 0 3 0 0 0 20 0 1 0 63 0 0 18446744073709551615 0 0 0 0 0 0 0 2147483647 0 1 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0",
+			Expectation: Expectation{S: &stat{Starttime: 63}},
+		},
 	}
 	for _, test := range tests {
 		t.Run(test.Name, func(t *testing.T) {