remove the switch for spending limit check

Author: AlexTugarev

components/server/ee/src/billing/billing-service.ts

@@ -7,7 +7,6 @@
 import { CostCenterDB } from "@gitpod/gitpod-db/lib";
 import { User } from "@gitpod/gitpod-protocol";
 import { AttributionId } from "@gitpod/gitpod-protocol/lib/attribution";
-import { ConfigCatClientFactory } from "@gitpod/gitpod-protocol/lib/experiments/configcat-server";
 import { log } from "@gitpod/gitpod-protocol/lib/util/logging";
 import { GetUpcomingInvoiceResponse } from "@gitpod/usage-api/lib/usage/v1/billing_pb";
 import {
@@ -31,7 +30,6 @@ export class BillingService {
     protected readonly usageServiceClientProvider: CachingUsageServiceClientProvider;
     @inject(CachingBillingServiceClientProvider)
     protected readonly billingServiceClientProvider: CachingBillingServiceClientProvider;
-    @inject(ConfigCatClientFactory) protected readonly configCatClientFactory: ConfigCatClientFactory;
 
     async checkSpendingLimitReached(user: User): Promise<SpendingLimitReachedResult> {
         const attributionId = await this.userService.getWorkspaceUsageAttributionId(user);
@@ -46,13 +44,6 @@ export class BillingService {
             };
         }
 
-        if (!(await this.isSpendingLimitCheckEnabled(user))) {
-            return {
-                reached: false,
-                attributionId,
-            };
-        }
-
         const upcomingInvoice = await this.getUpcomingInvoice(attributionId);
         const currentUsage = upcomingInvoice.getCredits();
         if (currentUsage >= costCenter.spendingLimit) {
@@ -84,13 +75,6 @@ export class BillingService {
         };
     }
 
-    protected async isSpendingLimitCheckEnabled(user: User): Promise<boolean> {
-        // introducing this enablement flag to be able to explicitly control the spending limit check during rollout
-        return await this.configCatClientFactory().getValueAsync("isSpendingLimitCheckEnabled", false, {
-            user: user,
-        });
-    }
-
     async getUpcomingInvoice(attributionId: AttributionId): Promise<GetUpcomingInvoiceResponse> {
         const response = await this.billingServiceClientProvider.getDefault().getUpcomingInvoice(attributionId);
         return response;