fix(gitpod-cli): ports list safe access to exposed url

Author: Andrea Falzetti

components/gitpod-cli/cmd/ports-list.go

@@ -48,21 +48,40 @@ var listPortsCmd = &cobra.Command{
 		table.SetCenterSeparator("|")
 
 		for _, port := range ports {
-			status := "not served"
+			status := ""
 			statusColor := tablewriter.FgHiBlackColor
-			if port.Exposed == nil && port.Tunneled == nil {
+			accessible := port.Exposed != nil || port.Tunneled != nil
+
+			exposedUrl := ""
+			if port.Exposed != nil {
+				exposedUrl = port.Exposed.Url
+			}
+
+			if !port.Served {
+				status = "not served"
+			} else if !accessible {
 				if port.AutoExposure == supervisor.PortAutoExposure_failed {
 					status = "failed to expose"
 					statusColor = tablewriter.FgRedColor
 				} else {
 					status = "detecting..."
 					statusColor = tablewriter.FgYellowColor
 				}
-			} else if port.Served {
-				status = "open (" + port.Exposed.Visibility.String() + ")"
-				if port.Exposed.Visibility == supervisor.PortVisibility_public {
+			} else {
+				if port.Tunneled != nil && port.Tunneled.Visibility == supervisor.TunnelVisiblity(supervisor.TunnelVisiblity_value["network"]) {
+					status = "open on all interfaces"
 					statusColor = tablewriter.FgHiGreenColor
-				} else {
+				}
+				if port.Tunneled != nil && port.Tunneled.Visibility == supervisor.TunnelVisiblity(supervisor.TunnelVisiblity_value["host"]) {
+					status = "open on localhost"
+					statusColor = tablewriter.FgHiGreenColor
+				}
+				if port.Exposed != nil && port.Exposed.Visibility == supervisor.PortVisibility_public {
+					status = "open (public)"
+					statusColor = tablewriter.FgHiGreenColor
+				}
+				if port.Exposed != nil && port.Exposed.Visibility == supervisor.PortVisibility_private {
+					status = "open (private)"
 					statusColor = tablewriter.FgHiCyanColor
 				}
 			}
@@ -82,7 +101,7 @@ var listPortsCmd = &cobra.Command{
 			}
 
 			table.Rich(
-				[]string{fmt.Sprint(port.LocalPort), status, port.Exposed.Url, nameAndDescription},
+				[]string{fmt.Sprint(port.LocalPort), status, exposedUrl, nameAndDescription},
 				colors,
 			)
 		}

components/supervisor/pkg/ports/ports.go

@@ -448,7 +448,8 @@ func (pm *Manager) autoExpose(ctx context.Context, localPort uint32, public bool
 			}
 			return
 		}
-		autoExpose.state = api.PortAutoExposure_succeeded
+		// autoExpose.state = api.PortAutoExposure_succeeded
+		autoExpose.state = api.PortAutoExposure_failed
 		log.WithField("localPort", localPort).Info("auto-exposed port")
 	}()
 	pm.autoExposed[localPort] = autoExpose