[dashboard] fix workspace start stuck in checking during ide onboarding

Author: mustard-mh

components/dashboard/src/App.tsx

@@ -150,6 +150,7 @@ function App() {
 
     const [loading, setLoading] = useState<boolean>(true);
     const [isWhatsNewShown, setWhatsNewShown] = useState(false);
+    const [showUserIdePreference, setShowUserIdePreference] = useState(false);
     const [isSetupRequired, setSetupRequired] = useState(false);
     const history = useHistory();
 
@@ -492,6 +493,9 @@ function App() {
     // Prefix with `/#referrer` will specify an IDE for workspace
     // We don't need to show IDE preference in this case
     const shouldUserIdePreferenceShown = User.isOnboardingUser(user) && !hash.startsWith(ContextURL.REFERRER_PREFIX);
+    if (shouldUserIdePreferenceShown !== showUserIdePreference) {
+        setShowUserIdePreference(shouldUserIdePreferenceShown);
+    }
 
     const isCreation = window.location.pathname === "/" && hash !== "";
     const isWsStart = /\/start\/?/.test(window.location.pathname) && hash !== "";
@@ -501,7 +505,11 @@ function App() {
         if (shouldUserIdePreferenceShown) {
             toRender = (
                 <StartPage phase={StartPhase.Checking}>
-                    <SelectIDEModal />
+                    <SelectIDEModal
+                        onClose={() => {
+                            setShowUserIdePreference(false);
+                        }}
+                    />
                 </StartPage>
             );
         } else {