[server] Implement a second getAllEnvVars() method that doesn't filter on repository pattern precedence

Author: jankeromnes

components/dashboard/src/settings/EnvironmentVariables.tsx

@@ -85,7 +85,7 @@ export default function EnvVars() {
     const [currentEnvVar, setCurrentEnvVar] = useState({ name: '', value: '', repositoryPattern: '' } as UserEnvVarValue);
     const [isAddEnvVarModalVisible, setAddEnvVarModalVisible] = useState(false);
     const update = async () => {
-        await getGitpodService().server.getEnvVars().then(r => setEnvVars(r));
+        await getGitpodService().server.getAllEnvVars().then(r => setEnvVars(r));
     }
 
     useEffect(() => {

components/gitpod-protocol/src/gitpod-service.ts

@@ -107,6 +107,7 @@ export interface GitpodServer extends JsonRpcServer<GitpodClient>, AdminServer,
 
     // user env vars
     getEnvVars(): Promise<UserEnvVarValue[]>;
+    getAllEnvVars(): Promise<UserEnvVarValue[]>;
     setEnvVar(variable: UserEnvVarValue): Promise<void>;
     deleteEnvVar(variable: UserEnvVarValue): Promise<void>;
 

components/server/src/auth/rate-limiter.ts

@@ -77,6 +77,7 @@ function readConfig(): RateLimiterConfig {
         "getUserStorageResource": { group: "default", points: 1 },
         "updateUserStorageResource": { group: "default", points: 1 },
         "getEnvVars": { group: "default", points: 1 },
+        "getAllEnvVars": { group: "default", points: 1 },
         "setEnvVar": { group: "default", points: 1 },
         "deleteEnvVar": { group: "default", points: 1 },
         "getContentBlobUploadUrl": { group: "default", points: 1 },

components/server/src/workspace/gitpod-server-impl.ts

@@ -1257,6 +1257,7 @@ export class GitpodServerImpl<Client extends GitpodClient, Server extends Gitpod
         return layoutData.layoutData;
     }
 
+    // Get environment variables (filter by repository pattern precedence)
     async getEnvVars(): Promise<UserEnvVarValue[]> {
         const user = this.checkUser("getEnvVars");
         const result = new Map<string, { value: UserEnvVar, score: number }>();
@@ -1274,6 +1275,24 @@ export class GitpodServerImpl<Client extends GitpodClient, Server extends Gitpod
             .map(({ value: { id, name, value, repositoryPattern } }) => ({ id, name, value, repositoryPattern }));
     }
 
+    // Get all environment variables (unfiltered)
+    async getAllEnvVars(): Promise<UserEnvVarValue[]> {
+        const user = this.checkUser("getAllEnvVars");
+        const result: UserEnvVarValue[] = [];
+        for (const value of await this.userDB.getEnvVars(user.id)) {
+            if (!await this.resourceAccessGuard.canAccess({ kind: 'envVar', subject: value }, 'get')) {
+                continue;
+            }
+            result.push({
+                id: value.id,
+                name: value.name,
+                value: value.value,
+                repositoryPattern: value.repositoryPattern,
+            });
+        }
+        return result;
+    }
+
     async setEnvVar(variable: UserEnvVarValue): Promise<void> {
         // Note: this operation is per-user only, hence needs no resource guard
         const user = this.checkUser("setEnvVar");