[ws-daemon] Remove stray "cannot write limit" errors

csweichel · roboquat · commit 40491e6ca7a0 · 2022-05-13T18:08:28.000+05:30
diff --git a/components/ws-daemon/pkg/cgroup/plugin_iolimit_v1.go b/components/ws-daemon/pkg/cgroup/plugin_iolimit_v1.go
@@ -179,7 +179,7 @@ func (c *IOLimiterV1) produceLimits(kind string, value int64, useCache bool) []s
 		return val.([]string)
 	}
 
-	lines := make([]string, len(c.devices))
+	lines := make([]string, 0, len(c.devices))
 	for _, dev := range c.devices {
 		lines = append(lines, fmt.Sprintf("%s %d", dev, value))
 	}
@@ -196,6 +196,9 @@ func writeLimit(limitPath string, content []string) error {
 	}
 
 	for _, l := range content {
+		if l == "" {
+			continue
+		}
 		err = os.WriteFile(limitPath, []byte(l), 0644)
 		if err != nil {
 			log.WithError(err).WithField("limitPath", limitPath).WithField("line", l).Warn("cannot write limit")

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ func (c *IOLimiterV1) produceLimits(kind string, value int64, useCache bool) []s`
`179`	`179`	`return val.([]string)`
`180`	`180`	`}`
`181`	`181`
`182`		`- lines := make([]string, len(c.devices))`
	`182`	`+ lines := make([]string, 0, len(c.devices))`
`183`	`183`	`for _, dev := range c.devices {`
`184`	`184`	`lines = append(lines, fmt.Sprintf("%s %d", dev, value))`
`185`	`185`	`}`
`@@ -196,6 +196,9 @@ func writeLimit(limitPath string, content []string) error {`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`for _, l := range content {`
	`199`	`+ if l == "" {`
	`200`	`+ continue`
	`201`	`+ }`
`199`	`202`	`err = os.WriteFile(limitPath, []byte(l), 0644)`
`200`	`203`	`if err != nil {`
`201`	`204`	`log.WithError(err).WithField("limitPath", limitPath).WithField("line", l).Warn("cannot write limit")`