Skip to content

Commit 44d50bc

Browse files
corneliusludmannroboquat
authored andcommitted
[server] Add and use supervisor image config
1 parent 5fb98d0 commit 44d50bc

File tree

4 files changed

+15
-3
lines changed

4 files changed

+15
-3
lines changed

chart/templates/server-ide-configmap.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ data:
4848
"ideVersion": "{{ .Values.components.workspace.codeImage.stableVersion }}",
4949
"ideImageRepo": "{{ template "gitpod.comp.imageRepo" (dict "root" . "gp" $.Values "comp" .Values.components.workspace.codeImage) }}",
5050
"ideImageAliases": {{ (include "ide-images-aliases" (dict "root" . "gp" $.Values)) | fromYaml | toJson }},
51-
"desktopIdeImageAliases": {{ (include "desktop-ide-images-aliases" (dict "root" . "gp" $.Values)) | fromYaml | toJson }}
51+
"desktopIdeImageAliases": {{ (include "desktop-ide-images-aliases" (dict "root" . "gp" $.Values)) | fromYaml | toJson }},
52+
"supervisorImage": "{{ template "gitpod.comp.imageFull" (dict "root" . "gp" $.Values "comp" .Values.components.workspace.supervisor) }}"
5253
}
5354
{{- end }}

components/gitpod-protocol/src/workspace-instance.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,4 +209,7 @@ export interface WorkspaceInstanceConfiguration {
209209

210210
// desktopIdeImage is the ref of the desktop IDE image this instance uses.
211211
desktopIdeImage?: string
212+
213+
// supervisorImage is the ref of the supervisor image this instance uses.
214+
supervisorImage?: string;
212215
}

components/server/src/ide-config.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ interface RawIDEConfig {
1818
ideImageRepo: string;
1919
ideImageAliases?: { [index: string]: string };
2020
desktopIdeImageAliases?: { [index: string]: string };
21+
supervisorImage: string;
2122
}
2223
const scheme = {
2324
"type": "object",
@@ -36,10 +37,14 @@ const scheme = {
3637
"type": "object",
3738
"additionalProperties": { "type": "string" }
3839
},
40+
"supervisorImage": {
41+
"type": "string"
42+
},
3943
},
4044
"required": [
4145
"ideVersion",
42-
"ideImageRepo"
46+
"ideImageRepo",
47+
"supervisorImage",
4348
]
4449
};
4550

@@ -49,6 +54,7 @@ export interface IDEConfig {
4954
ideImageAliases: { [index: string]: string };
5055
desktopIdeImageAliases: { [index: string]: string };
5156
ideImage: string;
57+
supervisorImage: string;
5258
}
5359

5460
@injectable()
@@ -120,7 +126,7 @@ export class IDEConfigService {
120126
},
121127
desktopIdeImageAliases: {
122128
...raw.desktopIdeImageAliases
123-
}
129+
},
124130
}
125131
}
126132

components/server/src/workspace/workspace-starter.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,7 @@ export class WorkspaceStarter {
309309
const configuration: WorkspaceInstanceConfiguration = {
310310
theiaVersion: ideConfig.ideVersion,
311311
ideImage: ideConfig.ideImage,
312+
supervisorImage: ideConfig.supervisorImage,
312313
};
313314

314315
const ideChoice = user.additionalData?.ideSettings?.defaultIde;
@@ -747,6 +748,7 @@ export class WorkspaceStarter {
747748
const startWorkspaceSpecIDEImage = new IDEImage();
748749
startWorkspaceSpecIDEImage.setWebRef(ideImage);
749750
startWorkspaceSpecIDEImage.setDesktopRef(instance.configuration?.desktopIdeImage || "");
751+
startWorkspaceSpecIDEImage.setSupervisorRef(instance.configuration?.supervisorImage || "");
750752
spec.setIdeImage(startWorkspaceSpecIDEImage);
751753
spec.setDeprecatedIdeImage(ideImage);
752754
spec.setWorkspaceImage(instance.workspaceImage);

0 commit comments

Comments
 (0)