Skip to content

Commit 45acc29

Browse files
easyCZroboquat
authored andcommitted
[public-api] Export metrics with package label instead of service
1 parent 76974dc commit 45acc29

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

components/public-api-server/pkg/server/metrics.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -45,44 +45,44 @@ func NewConnectMetrics() *ConnectMetrics {
4545
ServerRequestsStarted: prometheus.NewCounterVec(prometheus.CounterOpts{
4646
Name: "connect_server_started_total",
4747
Help: "Counter of server connect (gRPC/HTTP) requests started",
48-
}, []string{"service", "call", "call_type"}),
48+
}, []string{"package", "call", "call_type"}),
4949
ServerRequestsHandled: prometheus.NewHistogramVec(prometheus.HistogramOpts{
5050
Name: "connect_server_handled_seconds",
5151
Help: "Histogram of server connect (gRPC/HTTP) requests completed",
52-
}, []string{"service", "call", "call_type", "code"}),
52+
}, []string{"package", "call", "call_type", "code"}),
5353

5454
ClientRequestsStarted: prometheus.NewCounterVec(prometheus.CounterOpts{
5555
Name: "connect_client_started_total",
5656
Help: "Counter of client connect (gRPC/HTTP) requests started",
57-
}, []string{"service", "call", "call_type"}),
57+
}, []string{"package", "call", "call_type"}),
5858
ClientRequestsHandled: prometheus.NewHistogramVec(prometheus.HistogramOpts{
5959
Name: "connect_client_handled_seconds",
6060
Help: "Histogram of client connect (gRPC/HTTP) requests completed",
61-
}, []string{"service", "call", "call_type", "code"}),
61+
}, []string{"package", "call", "call_type", "code"}),
6262
}
6363
}
6464

6565
func NewMetricsInterceptor(metrics *ConnectMetrics) connect.UnaryInterceptorFunc {
6666
interceptor := func(next connect.UnaryFunc) connect.UnaryFunc {
6767
return connect.UnaryFunc(func(ctx context.Context, req connect.AnyRequest) (connect.AnyResponse, error) {
6868
now := time.Now()
69-
service, call := splitServiceCall(req.Spec().Procedure)
69+
callPackage, callName := splitServiceCall(req.Spec().Procedure)
7070
callType := streamType(req.Spec().StreamType)
7171
isClient := req.Spec().IsClient
7272

7373
if isClient {
74-
metrics.ClientRequestsStarted.WithLabelValues(service, call, callType)
74+
metrics.ClientRequestsStarted.WithLabelValues(callPackage, callName, callType)
7575
} else {
76-
metrics.ServerRequestsStarted.WithLabelValues(service, call, callType)
76+
metrics.ServerRequestsStarted.WithLabelValues(callPackage, callName, callType)
7777
}
7878

7979
resp, err := next(ctx, req)
8080

8181
code := codeOf(err)
8282
if isClient {
83-
metrics.ClientRequestsHandled.WithLabelValues(service, call, callType, code).Observe(time.Since(now).Seconds())
83+
metrics.ClientRequestsHandled.WithLabelValues(callPackage, callName, callType, code).Observe(time.Since(now).Seconds())
8484
} else {
85-
metrics.ServerRequestsHandled.WithLabelValues(service, call, callType, code).Observe(time.Since(now).Seconds())
85+
metrics.ServerRequestsHandled.WithLabelValues(callPackage, callName, callType, code).Observe(time.Since(now).Seconds())
8686
}
8787

8888
return resp, err

0 commit comments

Comments
 (0)