Skip to content

Commit 4bdcf8c

Browse files
iQQBotroboquat
authored andcommitted
use ide-proxy provide ide logo
1 parent 3f730b1 commit 4bdcf8c

File tree

11 files changed

+136
-88
lines changed

11 files changed

+136
-88
lines changed

chart/templates/proxy-configmap.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,13 @@ data:
6666

6767
{{- if not .Values.components.ideProxy.disabled }}
6868
vhost.ide: |
69-
https://ide-proxy.{$GITPOD_DOMAIN} {
69+
https://ide.{$GITPOD_DOMAIN} {
7070
import enable_log_debug
7171
import remove_server_header
7272
import ssl_configuration
7373
7474
reverse_proxy {
75-
to ide.{$KUBE_NAMESPACE}.{$KUBE_DOMAIN}:{{.Values.components.ideProxy.ports.http.servicePort}}
75+
to ide-proxy.{$KUBE_NAMESPACE}.{$KUBE_DOMAIN}:{{.Values.components.ideProxy.ports.http.servicePort}}
7676
}
7777
}
7878
{{- end }}

chart/templates/server-ide-configmap.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ options:
4646
orderKey: "00"
4747
title: "VS Code"
4848
type: "browser"
49-
logo: "vscode"
49+
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/vscode.svg"
5050
image: {{ (include "stable-image-full" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.codeImage)) }}
5151
code-latest:
5252
orderKey: "01"
5353
title: "VS Code"
5454
type: "browser"
55-
logo: "vscode-insiders"
55+
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/vscodeInsiders.svg"
5656
tooltip: "Early access version, still subject to testing."
5757
label: "Insiders"
5858
image: {{ (include "insider-image-full" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.codeImage)) }}
@@ -63,42 +63,42 @@ options:
6363
orderKey: "02"
6464
title: "VS Code"
6565
type: "desktop"
66-
logo: "vscode"
66+
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/vscode.svg"
6767
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.codeDesktop)) }}
6868
code-desktop-insiders:
6969
orderKey: "03"
7070
title: "VS Code"
7171
type: "desktop"
72-
logo: "vscode-insiders"
72+
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/vscodeInsiders.svg"
7373
tooltip: "Visual Studio Code Insiders for early adopters."
7474
label: "Insiders"
7575
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.codeDesktopInsiders)) }}
7676
intellij:
7777
orderKey: "04"
7878
title: "IntelliJ IDEA"
7979
type: "desktop"
80-
logo: "intellij-idea"
80+
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/intellijIdeaLogo.svg"
8181
notes: ["While in beta, when you open a workspace with IntelliJ IDEA you will need to use the password “gitpod”."]
8282
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.intellij)) }}
8383
goland:
8484
orderKey: "05"
8585
title: "GoLand"
8686
type: "desktop"
87-
logo: "goland"
87+
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/golandLogo.svg"
8888
notes: ["While in beta, when you open a workspace with GoLand you will need to use the password “gitpod”."]
8989
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.goland)) }}
9090
pycharm:
9191
orderKey: "06"
9292
title: "PyCharm"
9393
type: "desktop"
94-
logo: "https://upload.wikimedia.org/wikipedia/commons/1/1d/PyCharm_Icon.svg"
94+
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/pycharmLogo.svg"
9595
notes: ["While in beta, when you open a workspace with PyCharm you will need to use the password “gitpod”."]
9696
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.pycharm)) }}
9797
phpstorm:
9898
orderKey: "07"
9999
title: "PhpStorm"
100100
type: "desktop"
101-
logo: "https://upload.wikimedia.org/wikipedia/commons/c/c9/PhpStorm_Icon.svg"
101+
logo: "https://ide.{{ $.Values.hostname }}/image/ide-logo/phpstormLogo.svg"
102102
notes: ["While in beta, when you open a workspace with PhpStorm you will need to use the password “gitpod”."]
103103
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.phpstorm)) }}
104104

components/dashboard/src/images/golandLogo.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

components/dashboard/src/images/ideLogos.ts

Lines changed: 0 additions & 18 deletions
This file was deleted.

components/dashboard/src/images/intellijIdeaLogo.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

components/dashboard/src/images/vscode.svg

Lines changed: 0 additions & 11 deletions
This file was deleted.

components/dashboard/src/images/vscodeInsiders.svg

Lines changed: 0 additions & 37 deletions
This file was deleted.

components/dashboard/src/settings/Preferences.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { PageWithSubMenu } from "../components/PageWithSubMenu";
1212
import PillLabel from "../components/PillLabel";
1313
import SelectableCard from "../components/SelectableCard";
1414
import Tooltip from "../components/Tooltip";
15-
import ideLogos from '../images/ideLogos';
1615
import { getGitpodService } from "../service/service";
1716
import { ThemeContext } from "../theme-context";
1817
import { UserContext } from "../user-context";
@@ -215,7 +214,7 @@ function renderIdeOption(option: IDEOption, selected: boolean, onSelect: () => v
215214
const card = <SelectableCard className="w-36 h-40" title={option.title} selected={selected} onClick={onSelect}>
216215
<div className="flex justify-center mt-3">
217216
<img className="w-16 filter-grayscale self-center"
218-
src={option.logo.startsWith("http") ? option.logo : ideLogos[option.logo]} />
217+
src={option.logo} alt="logo" />
219218
</div>
220219
{option.label ? <div className={`font-semibold text-sm ${selected ? 'text-green-500' : 'text-gray-500 dark:text-gray-400'} uppercase mt-2 ml-2 px-3 py-1 self-center`}>{option.label}</div> : <></>}
221220
</SelectableCard>;
Lines changed: 44 additions & 0 deletions
Loading

0 commit comments

Comments
 (0)