Skip to content

Commit 52a824b

Browse files
committed
review updates
1 parent f87e6b6 commit 52a824b

File tree

12 files changed

+923
-354
lines changed

12 files changed

+923
-354
lines changed

components/dashboard/src/teams/TeamUsage.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,16 +89,14 @@ function TeamUsage() {
8989
} catch (error) {
9090
if (error.code === ErrorCodes.PERMISSION_DENIED) {
9191
setErrorMessage("Access to usage details is restricted to team owners.");
92+
} else {
93+
setErrorMessage(`Error: ${error?.message}`);
9294
}
9395
} finally {
9496
setIsLoading(false);
9597
}
9698
};
9799

98-
const handleSetPage = async (page: number) => {
99-
await loadPage(page);
100-
};
101-
102100
const getType = (type: BillableWorkspaceType) => {
103101
if (type === "regular") {
104102
return "Workspace";
@@ -304,7 +302,7 @@ function TeamUsage() {
304302
{usagePage && usagePage.totalPages > 1 && (
305303
<Pagination
306304
currentPage={usagePage.page}
307-
setPage={(page) => handleSetPage(page)}
305+
setPage={(page) => loadPage(page)}
308306
totalNumberOfPages={usagePage.totalPages}
309307
/>
310308
)}

components/gitpod-protocol/src/usage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export interface ListBilledUsageResponse {
5555
sessions: ExtendedBillableSession[];
5656
totalCreditsUsed: number;
5757
totalPages: number;
58-
total: number;
58+
totalSessions: number;
5959
perPage: number;
6060
page: number;
6161
}

components/server/ee/src/workspace/gitpod-server-impl.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2196,12 +2196,13 @@ export class GitpodServerEEImpl extends GitpodServerImpl {
21962196
};
21972197
}),
21982198
);
2199+
const pagination = response.getPagination();
21992200
return {
22002201
sessions,
2201-
total: response.getTotal(),
2202-
totalPages: response.getTotalPages(),
2203-
page: response.getPage(),
2204-
perPage: response.getPerPage(),
2202+
totalSessions: pagination?.getTotal() || 0,
2203+
totalPages: pagination?.getTotalPages() || 0,
2204+
page: pagination?.getPage() || 0,
2205+
perPage: pagination?.getPerPage() || 0,
22052206
totalCreditsUsed: response.getTotalCreditsUsed(),
22062207
};
22072208
}

0 commit comments

Comments
 (0)