Move tsc to validate changes. Run validations in parallel

Author: mads-hartmann

.werft/build.ts

@@ -11,7 +11,6 @@ import { deployToPreviewEnvironment } from "./jobs/build/deploy-to-preview-envir
 import { triggerIntegrationTests } from "./jobs/build/trigger-integration-tests";
 import { triggerSelfHostedPreview, triggerUpgradeTests } from "./jobs/build/self-hosted-upgrade-tests";
 import { jobConfig } from "./jobs/build/job-config";
-import { typecheckWerftJobs } from "./jobs/build/typecheck-werft-jobs";
 
 // Will be set once tracing has been initialized
 let werft: Werft;
@@ -57,12 +56,12 @@ async function run(context: any) {
         await triggerUpgradeTests(werft, config, context.Owner);
         return;
     }
-    await typecheckWerftJobs(werft);
+
     await buildAndPublish(werft, config);
 
     if (config.withSelfHostedPreview) {
         await triggerSelfHostedPreview(werft, config, context.Owner);
-        return
+        return;
     }
 
     if (!config.withPreview || config.publishRelease) {

.werft/jobs/build/build-and-publish.ts

@@ -45,7 +45,8 @@ export async function buildAndPublish(werft: Werft, jobConfig: JobConfig) {
     if (publishRelease) {
         exec(`gcloud auth activate-service-account --key-file "/mnt/secrets/gcp-sa-release/service-account.json"`);
     }
-    exec(
+
+    await exec(
         `leeway build --docker-build-options network=host --werft=true -c remote ${
             dontTest ? "--dont-test" : ""
         } ${retag} --coverage-output-path=${coverageOutput} -Dversion=${version} -DremoveSources=false -DimageRepoBase=${imageRepo} -DlocalAppVersion=${localAppVersion} -DSEGMENT_IO_TOKEN=${
@@ -55,6 +56,7 @@ export async function buildAndPublish(werft: Werft, jobConfig: JobConfig) {
         } -DnpmPublishTrigger=${publishToNpm ? Date.now() : "false"} -DjbMarketplacePublishTrigger=${
             publishToJBMarketplace ? Date.now() : "false"
         }`,
+        { async: true },
     );
     if (publishRelease) {
         try {

.werft/jobs/build/typecheck-werft-jobs.ts

@@ -5,8 +5,7 @@ import { JobConfig } from "./job-config";
 export async function validateChanges(werft: Werft, config: JobConfig) {
     werft.phase("validate-changes", "validating changes");
     try {
-        branchNameCheck(werft, config);
-        preCommitCheck(werft);
+        await Promise.all([branchNameCheck(werft, config), preCommitCheck(werft), typecheckWerftJobs(werft)]);
     } catch (err) {
         werft.fail("validate-changes", err);
     }
@@ -35,10 +34,29 @@ async function branchNameCheck(werft: Werft, config: JobConfig) {
 
 async function preCommitCheck(werft: Werft) {
     werft.log("pre-commit checks", "Running pre-commit hooks.");
-    const preCommitCmd = exec(`pre-commit run --show-diff-on-failure`, { slice: "pre-commit checks" });
+    const preCommitCmd = await exec(`pre-commit run --show-diff-on-failure`, {
+        slice: "pre-commit checks",
+        async: true,
+    });
 
     if (preCommitCmd.code != 0) {
         throw new Error(preCommitCmd.stderr.toString().trim());
     }
     werft.done("pre-commit checks");
 }
+
+/**
+ * This validates all the .ts files inside of the .werft folder and fails the
+ * build if there are compile errors.
+ */
+export async function typecheckWerftJobs(werft: Werft) {
+    const slice = "tsc --noEmit";
+    try {
+        werft.log(slice, "Typechecking Werft Typescript files");
+        await exec("cd .werft && tsc --noEmit", { slice, async: true });
+        werft.log(slice, "No compilation errors");
+    } catch (e) {
+        werft.fail(slice, e);
+    }
+    werft.done(slice);
+}