Skip to content

Commit 65b2a13

Browse files
committed
[installer-tests] fix cluster issuer test condition
1 parent c4d0f69 commit 65b2a13

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

install/tests/Makefile

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,11 +146,11 @@ add-ns-record: check-env-cloud
146146
terraform apply -target=module.$(cloud)-add-dns-record -var kubeconfig=${KUBECONFIG} --auto-approve
147147
@echo "Done adding NS record"
148148

149-
self_signed ?= "false"
149+
self_signed ?= false
150150
.PHONY:
151151
## cluster-issuer: Creates a cluster issuer for the correspondign provider
152152
cluster-issuer: check-env-cloud
153-
ifneq ($(self_signed), "true")
153+
ifeq (true,$(self_signed))
154154
@echo "Skipped creating cluster issuer"
155155
else
156156
terraform init --upgrade && \
@@ -391,9 +391,11 @@ gitpod-debug-info:
391391
check-kots-app:
392392
kubectl kots get --kubeconfig=${KUBECONFIG} app gitpod -n gitpod | grep gitpod | awk '{print $$2}' | grep "ready" || { $(MAKE) gitpod-debug-info; exit 1; }
393393

394+
self_signed ?= false
395+
394396
check-gitpod-installation: delete-cm-setup check-kots-app check-env-sub-domain
395397
@echo "Curling https://${TF_VAR_TEST_ID}.${TF_VAR_domain}/api/version"
396-
ifneq ($(self_signed),)
398+
ifeq (true,$(self_signed))
397399
export SSL_CERT_FILE=./ca.pem
398400
endif
399401
curl -i -X GET https://${TF_VAR_TEST_ID}.${TF_VAR_domain}/api/version || { echo "Curling Gitpod endpoint failed"; exit 1; }

0 commit comments

Comments
 (0)